You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "zyfeier (via GitHub)" <gi...@apache.org> on 2023/03/15 06:47:39 UTC
[GitHub] [nuttx] zyfeier opened a new pull request, #8823: assert: add header file
zyfeier opened a new pull request, #8823:
URL: https://github.com/apache/nuttx/pull/8823
## Summary
Add missing assert.h header file.
## Impact
NA
## Testing
CI Pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #8823: arch: add more dependent header file
Posted by "gustavonihei (via GitHub)" <gi...@apache.org>.
gustavonihei commented on code in PR #8823:
URL: https://github.com/apache/nuttx/pull/8823#discussion_r1143719414
##########
sched/mqueue/mq_send.c:
##########
@@ -22,18 +22,18 @@
* Included Files
****************************************************************************/
-#include <nuttx/config.h>
-
-#include <sys/types.h>
-#include <mqueue.h>
-#include <errno.h>
-#include <debug.h>
-
-#include <nuttx/irq.h>
-#include <nuttx/arch.h>
-#include <nuttx/cancelpt.h>
-
-#include "mqueue/mqueue.h"
+#include <nuttx/config.h>
+#include <nuttx/arch.h>
+#include <nuttx/cancelpt.h>
+#include <nuttx/irq.h>
Review Comment:
In my opinion these (with the exception of `nuttx/config.h`) could be left in their current placement, after the C system headers.
But since the include order is not enforced by the NuttX coding standard, I won't block the PR for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] zyfeier commented on pull request #8823: arch: add more dependent header file
Posted by "zyfeier (via GitHub)" <gi...@apache.org>.
zyfeier commented on PR #8823:
URL: https://github.com/apache/nuttx/pull/8823#issuecomment-1502739296
@pkarashchenko If there are no issues with this PR, could you help merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko merged pull request #8823: arch: add more dependent header file
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko merged PR #8823:
URL: https://github.com/apache/nuttx/pull/8823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org