You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Kamesh Jayachandran <ka...@collab.net> on 2006/11/16 13:43:11 UTC
Re: svn commit: r22294 - in trunk/subversion: include libsvn_ra_dav
> Modified:
> trunk/subversion/include/svn_ra.h
> trunk/subversion/libsvn_ra_dav/util.c
>
Copyright year need to be bumped for both the files.
> + if (ras->callbacks->cancel_func)
> + SVN_ERR((ras->callbacks->cancel_func)(ras->callback_baton));
> +
>
I don't know much here, but of curiosity What is the guarantee that
'ras' and 'ras->callbacks' being non-null?
With regards
Kamesh Jayachandran
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r22294 - in trunk/subversion: include libsvn_ra_dav
Posted by Erik Huelsmann <eh...@gmail.com>.
On 11/16/06, Kamesh Jayachandran <ka...@collab.net> wrote:
>
> > Modified:
> > trunk/subversion/include/svn_ra.h
> > trunk/subversion/libsvn_ra_dav/util.c
> >
>
> Copyright year need to be bumped for both the files.
Will do.
> > + if (ras->callbacks->cancel_func)
> > + SVN_ERR((ras->callbacks->cancel_func)(ras->callback_baton));
> > +
> I don't know much here, but of curiosity What is the guarantee that
> 'ras' and 'ras->callbacks' being non-null?
ras being non-null is an api requirement, but, you're right: callbacks
could be NULL.
Will fix. Thanks.
bye,
Erik.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org