You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/10/27 17:45:08 UTC
[GitHub] [ozone] umamaheswararao opened a new pull request #2777: HDDS-5874 EC: Integrate the Codec changes into EC Streams.
umamaheswararao opened a new pull request #2777:
URL: https://github.com/apache/ozone/pull/2777
## What changes were proposed in this pull request?
Integrated the codec changes with streams
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5874
## How was this patch tested?
Existing tests would use this copied codec now. and Tests are passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao merged pull request #2777: HDDS-5874 EC: Integrate the Codec changes into EC Streams.
Posted by GitBox <gi...@apache.org>.
umamaheswararao merged pull request #2777:
URL: https://github.com/apache/ozone/pull/2777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel commented on a change in pull request #2777: HDDS-5874 EC: Integrate the Codec changes into EC Streams.
Posted by GitBox <gi...@apache.org>.
sodonnel commented on a change in pull request #2777:
URL: https://github.com/apache/ozone/pull/2777#discussion_r740149699
##########
File path: hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/TestOzoneECClient.java
##########
@@ -75,21 +69,19 @@
private byte[][] inputChunks = new byte[dataBlocks][chunkSize];
private final XceiverClientFactory factoryStub =
new MockXceiverClientFactory();
- private MockOmTransport transportStub = null;
- private ECSchema schema = new ECSchema("rs", dataBlocks, parityBlocks);
- private ErasureCodecOptions options = new ErasureCodecOptions(schema);
private OzoneConfiguration conf = new OzoneConfiguration();
- private RSErasureCodec codec = new RSErasureCodec(conf, options);
- private final RawErasureEncoder encoder = CodecUtil.createRawEncoder(conf,
- SystemErasureCodingPolicies.getPolicies().get(1).getCodecName(),
- codec.getCoderOptions());
+ private MockOmTransport transportStub = new MockOmTransport(
+ new MultiNodePipelineBlockAllocator(conf, dataBlocks + parityBlocks));
+ private final RawErasureEncoder encoder =
+ new RSRawErasureCoderFactory().createEncoder(
+ new ECReplicationConfig(dataBlocks, parityBlocks));
@Before
public void init() throws IOException {
conf.setStorageSize(OzoneConfigKeys.OZONE_SCM_BLOCK_SIZE, 2,
StorageUnit.KB);
- transportStub = new MockOmTransport(
- new MultiNodePipelineBlockAllocator(conf, dataBlocks + parityBlocks));
+ //transportStub = new MockOmTransport(
+ // new MultiNodePipelineBlockAllocator(conf, dataBlocks + parityBlocks));
Review comment:
Should we remove the commented lines here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org