You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/15 04:01:29 UTC

[GitHub] [flink] xintongsong commented on pull request #15599: [FLINK-11838][flink-gs-fs-hadoop] Create Google Storage file system with recoverable writer support

xintongsong commented on pull request #15599:
URL: https://github.com/apache/flink/pull/15599#issuecomment-861150767


   Thanks for updating the PR, @galenwarren.
   
   - The Azure build has been triggered, on your latest commit (e751250). It's probably not very timely.
   - It's good to hear that excluding `javax.annotation-api` works. That indeed fixes part of the problems. The complaint regarding prohibited GPL license has gone.
   - The `LicenseChecker` is still complaining about `Found a total of 1 severe license issues`. After checking the code, I found `Module flink-gs-fs-hadoop is missing a NOTICE file.` is considered as a severe issues. Admittedly, this is a bit implicit being logged at the warning level.
     - Could you please add a NOTICE file for this new module? You can take a look at this [guidelines](https://cwiki.apache.org/confluence/display/FLINK/Licensing).
     - I'll open a separate ticket taking care of the logging level issue.
   
   Except for the licensing issue, are we ready for another round of review? I noticed you have pushed a commit for adding logs. How is the rework of unit tests going?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org