You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "krisztina-zsihovszki (via GitHub)" <gi...@apache.org> on 2023/03/03 15:52:13 UTC
[GitHub] [nifi] krisztina-zsihovszki commented on a diff in pull request #6976: NIFI-11204: Add configurable retry logic for table commits in PutIceberg processor
krisztina-zsihovszki commented on code in PR #6976:
URL: https://github.com/apache/nifi/pull/6976#discussion_r1124549751
##########
nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/src/main/resources/docs/org.apache.nifi.processors.iceberg.PutIceberg/additionalDetails.html:
##########
@@ -0,0 +1,57 @@
+<!DOCTYPE html>
+<html lang="en" xmlns="http://www.w3.org/1999/html">
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+
+ <head>
+ <meta charset="utf-8"/>
+ <title>PutIceberg</title>
+ <link rel="stylesheet" href="../../../../../css/component-usage.css" type="text/css"/>
+ </head>
+
+ <body>
+
+ <h1>PutIceberg</h1>
+
+ <h3>Description</h3>
+ <p>
+ Iceberg is a high-performance format for huge analytic tables.
+ The PutIceberg processor is capable to push data into iceberg tables using different type of Iceberg catalog implementations.
Review Comment:
"... is capable of pushing data into Iceberg tables using different types of ..."
##########
nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/src/main/java/org/apache/nifi/processors/iceberg/PutIceberg.java:
##########
@@ -113,6 +116,42 @@ public class PutIceberg extends AbstractIcebergProcessor {
.addValidator(StandardValidators.LONG_VALIDATOR)
.build();
+ static final PropertyDescriptor NUMBER_OF_COMMIT_RETRIES = new PropertyDescriptor.Builder()
+ .name("number-of-commit-retries")
+ .displayName("Number Of Commit Retries")
Review Comment:
It is "Number of Commit Retries" in Title Case.
##########
nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/src/main/resources/docs/org.apache.nifi.processors.iceberg.PutIceberg/additionalDetails.html:
##########
@@ -0,0 +1,57 @@
+<!DOCTYPE html>
+<html lang="en" xmlns="http://www.w3.org/1999/html">
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+
+ <head>
+ <meta charset="utf-8"/>
+ <title>PutIceberg</title>
+ <link rel="stylesheet" href="../../../../../css/component-usage.css" type="text/css"/>
+ </head>
+
+ <body>
+
+ <h1>PutIceberg</h1>
+
+ <h3>Description</h3>
+ <p>
+ Iceberg is a high-performance format for huge analytic tables.
+ The PutIceberg processor is capable to push data into iceberg tables using different type of Iceberg catalog implementations.
+ </p>
+
+ <h3>Commit retry properties</h3>
+ <p>
+ Iceberg supports multiple concurrent writes using optimistic concurrency. The processor provides properties to properly configure the commit retry behaviour according to its usage.
+
+ <ul>
+ <li>
+ Number Of Commit Retries (default: 3) - Number of retries that the processor is going to try to commit the new data files.
+ </li>
+ <li>
+ Minimum Commit Wait Time (default: 100 ms) - Minimum time that the processor is going to wait before each commit attempts.
Review Comment:
each commit attempt
##########
nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/src/main/resources/docs/org.apache.nifi.processors.iceberg.PutIceberg/additionalDetails.html:
##########
@@ -0,0 +1,57 @@
+<!DOCTYPE html>
+<html lang="en" xmlns="http://www.w3.org/1999/html">
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+
+ <head>
+ <meta charset="utf-8"/>
+ <title>PutIceberg</title>
+ <link rel="stylesheet" href="../../../../../css/component-usage.css" type="text/css"/>
+ </head>
+
+ <body>
+
+ <h1>PutIceberg</h1>
+
+ <h3>Description</h3>
+ <p>
+ Iceberg is a high-performance format for huge analytic tables.
+ The PutIceberg processor is capable to push data into iceberg tables using different type of Iceberg catalog implementations.
+ </p>
+
+ <h3>Commit retry properties</h3>
+ <p>
+ Iceberg supports multiple concurrent writes using optimistic concurrency. The processor provides properties to properly configure the commit retry behaviour according to its usage.
+
+ <ul>
+ <li>
+ Number Of Commit Retries (default: 3) - Number of retries that the processor is going to try to commit the new data files.
+ </li>
+ <li>
+ Minimum Commit Wait Time (default: 100 ms) - Minimum time that the processor is going to wait before each commit attempts.
+ </li>
+ <li>
+ Maximum Commit Wait Time (default: 100 ms) - Maximum time that the processor is going to wait before each commit attempts.
Review Comment:
The Maximum Commit Wait Time is 1 min.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org