You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by Volkan Yazıcı <vo...@yazi.ci> on 2021/11/01 08:48:19 UTC
Re: [apache/logging-log4j2] LOG4J2-3182 (PR #593)

Would anybody mind reviewing #593
<https://github.com/apache/logging-log4j2/pull/593> associated with
LOG4J2-3182 <https://issues.apache.org/jira/browse/LOG4J2-3182>, please? It
is ~10 LoC in total and looks innocent. Should be easy to review for
somebody who is familiar with LoggerContext and dispatchers in
AsyncAppender.

On Fri, Oct 29, 2021 at 4:47 AM foryasuaki <no...@github.com> wrote:

> With MonitorInterval, if new config start failed, the previous
> watchmanager and scheduler will never shut down.
>
> Besides, the async threads will increase.
>
> This is for fixing this issue
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
>   https://github.com/apache/logging-log4j2/pull/593
> Commit Summary
>
>    - Always close the wrongly started threads and schedulers
>    <https://github.com/apache/logging-log4j2/pull/593/commits/b8146e83752cc823d005f7e6088268fbdbc3726b>
>    - Fix the monitorinterval thread leak issue
>    <https://github.com/apache/logging-log4j2/pull/593/commits/0ff36c0bf27329d4508283df0551909124484fcb>
>
> File Changes
>
> (2 files <https://github.com/apache/logging-log4j2/pull/593/files>)
>
>    - *M*
>    log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java
>    <https://github.com/apache/logging-log4j2/pull/593/files#diff-c25f43f73c9a13c09eac7d2232a4d7a88b91f4adf22fbd3a013d066e16d000d8>
>    (7)
>    - *M*
>    log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppender.java
>    <https://github.com/apache/logging-log4j2/pull/593/files#diff-6b30d73942796a35c3bcf93d46127d03cb6959fb69fb8eb84c4c6fca13bb68e6>
>    (4)
>
> Patch Links:
>
>    - https://github.com/apache/logging-log4j2/pull/593.patch
>    - https://github.com/apache/logging-log4j2/pull/593.diff
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/logging-log4j2/pull/593>, or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAARTSJNY2WO3TARYNLSLG3UJIDMJANCNFSM5G6JCYFQ>
> .
>