You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/13 10:01:09 UTC

[GitHub] [arrow-rs] jhorstmann commented on pull request #1300: Add `DictionaryArray::try_new()` to create dictionaries from pre existing arrays

jhorstmann commented on pull request #1300:
URL: https://github.com/apache/arrow-rs/pull/1300#issuecomment-1037978864


   Looks good. The double validation for the dictionary values is a bit unfortunate, but since this is mostly a convenience feature that should be fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org