[GitHub] [flink] XComp commented on pull request #14499: [FLINK-15156] Warn user if System.exit() is called in user code

[GitBox <gi...@apache.org>]

XComp commented on pull request #14499:
URL: https://github.com/apache/flink/pull/14499#issuecomment-752619323


   I'm going to add the remarks on where System.exit handling should be added here separately:
   
   Two other locations @rmetzger mentioned in [FLINK-15156](https://issues.apache.org/jira/browse/FLINK-15156) were:
   * [ExecutionGraph.vertexFinished:1149](https://github.com/apache/flink/blob/c6997c97c575d334679915c328792b8a3067cfb5/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java#L1149) where it calls `finalizeOnMaster(..)` on each `JobVertex`
   * [ExecutionGraphBuilder.buildGraph:222](https://github.com/apache/flink/blob/c6997c97c575d334679915c328792b8a3067cfb5/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraphBuilder.java#L222) calls `initializeOnMaster(..)` on each `JobVertex`
   I might not have the full understanding of the call hierarchies: Are these two locations covered by your current version of the code?
   
   @rmetzger May you have another look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org