[GitHub] [apisix] tokers commented on a change in pull request #4313: feat: nacos discovery support namespace

[GitBox <gi...@apache.org>]

tokers commented on a change in pull request #4313:
URL: https://github.com/apache/apisix/pull/4313#discussion_r640240356



##########
File path: docs/en/latest/discovery/nacos.md
##########
@@ -99,3 +99,46 @@ The format response as below:
   "action": "set"
 }
 ```
+
+Example of routing a request with a URL of "/nacosWithNamespaceId/*" to a service which name, namespaceId "http://192.168.33.1:8848/nacos/v1/ns/instance/list?serviceName=APISIX-NACOS&namespaceId=test_ns" and use nacos discovery client in the registry :

Review comment:
       ```suggestion
   Example of routing a request with a URL of "/nacosWithNamespaceId/*" to a service which name, namespaceId "http://192.168.33.1:8848/nacos/v1/ns/instance/list?serviceName=APISIX-NACOS&namespaceId=test_ns" and use nacos discovery client in the registry:
   ```

##########
File path: docs/en/latest/discovery/nacos.md
##########
@@ -99,3 +99,46 @@ The format response as below:
   "action": "set"
 }
 ```
+
+Example of routing a request with a URL of "/nacosWithNamespaceId/*" to a service which name, namespaceId "http://192.168.33.1:8848/nacos/v1/ns/instance/list?serviceName=APISIX-NACOS&namespaceId=test_ns" and use nacos discovery client in the registry :
+
+```shell
+$ curl http://127.0.0.1:9080/apisix/admin/routes/2 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '
+{
+    "uri": "/nacosWithNamespaceId/*",
+    "upstream": {
+        "service_name": "APISIX-NACOS",
+        "type": "roundrobin",
+        "discovery_type": "nacos",
+        "nacos_namespace_id": "test_ns"
+    }
+}'
+```
+
+The format response as below:

Review comment:
       ```suggestion
   The formatted response as below:
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org