You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by chitin <gi...@git.apache.org> on 2016/11/03 10:07:30 UTC
[GitHub] incubator-eagle pull request #606: EAGLE-643 Implement oozieAuditLogAppProvi...
GitHub user chitin opened a pull request:
https://github.com/apache/incubator-eagle/pull/606
EAGLE-643 Implement oozieAuditLogAppProvider
EAGLE-643 Implement oozieAuditLogAppProvider
- Add provider for oozie audit log
https://issues.apache.org/jira/browse/EAGLE-643
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chitin/incubator-eagle EAGLE-643
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/606.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #606
----
commit 3fe5b9edfd86c3d4b5556c4a15fcde740372e97a
Author: chitin <ch...@gmail.com>
Date: 2016-11-03T10:05:31Z
EAGLE-643 Implement oozieAuditLogAppProvider
- Add provider for oozie audit log
https://issues.apache.org/jira/browse/EAGLE-643
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #606: EAGLE-643 Implement oozieAuditLogAppProvider
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/incubator-eagle/pull/606
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #606: EAGLE-643 Implement oozieAuditLogAppProvider
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/incubator-eagle/pull/606
BTW: Could you please provide more description or screenshot about the feature?
For example:
- Installation Dialog Screenshot
- Populated Stream Schema
- Any UI features?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #606: EAGLE-643 Implement oozieAuditLogAppProvi...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/606#discussion_r87327457
--- Diff: eagle-security/eagle-security-oozie-auditlog/src/main/resources/META-INF/providers/org.apache.eagle.security.oozie.parse.OozieAuditLogAppProvider.xml ---
@@ -0,0 +1,250 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<application>
+ <type>OOZIE_AUDIT_LOG_MONITOR</type>
+ <name>Oozie Audit Log Monitor</name>
+ <version>0.5.0-incubating</version>
+ <appClass>org.apache.eagle.security.oozie.parse.OozieAuditLogApplication</appClass>
+ <configuration>
+ <!-- topology related configurations -->
+ <property>
+ <name>workers</name>
+ <displayName>workers</displayName>
+ <value>1</value>
+ <description>number of topology workers</description>
+ </property>
+ <property>
+ <name>topology.numOfJoinTasks</name>
+ <displayName>topology.numOfJoinTasks</displayName>
--- End diff --
Please change `displayName` of all properties in configuration descriptor to **human-readable name**, for example: topology.numOfJoinTasks -> "Join Tasks Num"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #606: EAGLE-643 Implement oozieAuditLogAppProvi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-eagle/pull/606
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #606: EAGLE-643 Implement oozieAuditLogAppProvi...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/606#discussion_r87172938
--- Diff: eagle-security/eagle-security-oozie-auditlog/src/main/java/org/apache/eagle/security/oozie/parse/OozieAuditLogAppProvider.java ---
@@ -0,0 +1,13 @@
+package org.apache.eagle.security.oozie.parse;
--- End diff --
Missing license header
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---