You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/30 06:07:00 UTC
[jira] [Commented] (FLINK-9473) Compilation fails after upgrade to
Calcite 1.17
[ https://issues.apache.org/jira/browse/FLINK-9473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494729#comment-16494729 ]
ASF GitHub Bot commented on FLINK-9473:
---------------------------------------
GitHub user snuyanzin opened a pull request:
https://github.com/apache/flink/pull/6099
[FLINK-9473][Table API & SQL] Added new methods into ExternalCatalogSchema based on interface Schema changes in Calcite
## What is the purpose of the change
Make Flink compilable after Calcite version bump to 1.17.0
## Brief change log
- *new abstract methods dummy implementation*
- *bump calcite version to 1.17.0-SNAPSHOT*
## Verifying this change
to verify need to check if it or compilable or not e.g.
*mvn clean package -DskipTests*
This change added tests and can be verified as follows:
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no )
- The runtime per-record code paths (performance sensitive): (no )
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no )
- The S3 file system connector: (no )
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable )
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/snuyanzin/flink FLINK_9473
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6099.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6099
----
commit 61fda81fa46a7594c9a54450b525a5c321866324
Author: snuyanzin <sn...@...>
Date: 2018-05-30T06:05:24Z
Make Flink compilable after bump calcite version to 1.17
----
> Compilation fails after upgrade to Calcite 1.17
> -----------------------------------------------
>
> Key: FLINK-9473
> URL: https://issues.apache.org/jira/browse/FLINK-9473
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Sergey Nuyanzin
> Assignee: Sergey Nuyanzin
> Priority: Major
>
> {noformat}
> /apacheFlink/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala:40: error: class ExternalCatalogSchema needs to be abstract, since:
> [ERROR] it has 2 unimplemented members.
> [ERROR] /** As seen from class ExternalCatalogSchema, the missing signatures are as follows.
> [ERROR] * For convenience, these are usable as stub implementations.
> [ERROR] */
> [ERROR] def getType(x$1: String): org.apache.calcite.rel.type.RelProtoDataType = ???
> [ERROR] def getTypeNames(): java.util.Set[String] = ???
> [ERROR]
> [ERROR] class ExternalCatalogSchema(
> [ERROR] ^
> [WARNING] two warnings found
> [ERROR] one error found
> {noformat}
> while https://issues.apache.org/jira/browse/CALCITE-2045 into interface _org.apache.calcite.schema.Schema_ there were introduced two more methods: _org.apache.calcite.schema.Schema#getTypeNames_, _org.apache.calcite.schema.Schema#getType_
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)