You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "NishthaShah (via GitHub)" <gi...@apache.org> on 2026/09/29 05:57:17 UTC
[PR] fix: log-message typos (druid)
NishthaShah opened a new pull request, #20449:
URL: https://github.com/apache/druid/pull/20449
### Description
Fixes two user-visible log-message typos:
- `SwitchingEmitterModule`: `"Createing Switching emitter…"` → `"Creating Switching emitter…"` (`log.info` on emitter startup)
- `AbstractBatchIndexTask`: `"Interrupted while waiting for segment availablity…"` → `"…availability…"` (`log.warn` on interrupt during segment-availability wait)
No behavior change; no tests required.
##### Key changed/added classes in this PR
* `SwitchingEmitterModule`
* `AbstractBatchIndexTask`
This PR has:
- [x] been self-reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] fix: log-message typos (druid)
Posted by "FrankChen021 (via GitHub)" <gi...@apache.org>.
FrankChen021 merged PR #20449:
URL: https://github.com/apache/druid/pull/20449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] fix: log-message typos (druid)
Posted by "NishthaShah (via GitHub)" <gi...@apache.org>.
NishthaShah commented on PR #20449:
URL: https://github.com/apache/druid/pull/20449#issuecomment-5885104971
Coverage-jacoco is failing with `Insufficient line coverage of 0% (0/1)`. The single flagged line is `AbstractBatchIndexTask.java:765`, which is inside `catch (InterruptedException)`; the existing `waitForSegmentAvailability` tests don't exercise the interrupt path, so the pre-existing coverage on that line is also 0.
This PR only edits the log-message string (`availablity` -> `availability`); there is no logic change, and the branch that produces the line was already uncovered before the PR. Would a committer be willing to bypass the diff-coverage check, or would you prefer I add a separate test that interrupts the wait? Happy to do whichever is easier to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org