(maven-changes-plugin) branch master updated: Infer types (#116)

[el...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

elharo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-changes-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new 6fd3cb8  Infer types (#116)
6fd3cb8 is described below

commit 6fd3cb84bc291f4b37aa0896d286c0e93efca814
Author: Elliotte Rusty Harold <el...@users.noreply.github.com>
AuthorDate: Wed Mar 5 12:54:46 2025 +0000

    Infer types (#116)
    
    * Infer types
---
 src/main/java/org/apache/maven/plugins/changes/ChangesXML.java      | 2 +-
 .../org/apache/maven/plugins/changes/ChangesValidatorMojoTest.java  | 6 +++---
 .../maven/plugins/changes/announcement/AnnouncementMojoTest.java    | 2 +-
 .../apache/maven/plugins/changes/github/GitHubDownloaderTest.java   | 5 ++---
 4 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/src/main/java/org/apache/maven/plugins/changes/ChangesXML.java b/src/main/java/org/apache/maven/plugins/changes/ChangesXML.java
index 323fa16..286dd79 100644
--- a/src/main/java/org/apache/maven/plugins/changes/ChangesXML.java
+++ b/src/main/java/org/apache/maven/plugins/changes/ChangesXML.java
@@ -134,7 +134,7 @@ public class ChangesXML {
      * @return the current value of the {@link ChangesXML#releaseList} attribute
      */
     public List<Release> getReleaseList() {
-        return releaseList == null ? Collections.<Release>emptyList() : releaseList;
+        return releaseList == null ? Collections.emptyList() : releaseList;
     }
 
     /**
diff --git a/src/test/java/org/apache/maven/plugins/changes/ChangesValidatorMojoTest.java b/src/test/java/org/apache/maven/plugins/changes/ChangesValidatorMojoTest.java
index 7c76e2d..91645d0 100644
--- a/src/test/java/org/apache/maven/plugins/changes/ChangesValidatorMojoTest.java
+++ b/src/test/java/org/apache/maven/plugins/changes/ChangesValidatorMojoTest.java
@@ -35,7 +35,7 @@ public class ChangesValidatorMojoTest extends AbstractMojoTestCase {
     public void setUp() throws Exception {
         super.setUp();
         File pom = new File(getBasedir(), "/src/test/unit/plugin-config.xml");
-        mojo = (ChangesValidatorMojo) lookupMojo("changes-validate", pom);
+        mojo = lookupMojo("changes-validate", pom);
     }
 
     public void testValidationSuccess() throws Exception {
@@ -53,9 +53,9 @@ public class ChangesValidatorMojoTest extends AbstractMojoTestCase {
         setVariableValueToObject(mojo, "failOnError", Boolean.TRUE);
         try {
             mojo.execute();
-            fail(" a MojoExecutionException should occur here changes file is not valid and failOnError is true ");
+            fail(" A MojoExecutionException should occur here. Changes file is not valid and failOnError is true ");
         } catch (MojoExecutionException e) {
-            // we except exception here
+            // expected
         }
     }
 
diff --git a/src/test/java/org/apache/maven/plugins/changes/announcement/AnnouncementMojoTest.java b/src/test/java/org/apache/maven/plugins/changes/announcement/AnnouncementMojoTest.java
index c957245..4b4af6a 100644
--- a/src/test/java/org/apache/maven/plugins/changes/announcement/AnnouncementMojoTest.java
+++ b/src/test/java/org/apache/maven/plugins/changes/announcement/AnnouncementMojoTest.java
@@ -32,7 +32,7 @@ public class AnnouncementMojoTest extends AbstractMojoTestCase {
 
     public void testAnnounceGeneration() throws Exception {
         File pom = new File(getBasedir(), "/src/test/unit/plugin-config.xml");
-        AnnouncementMojo mojo = (AnnouncementMojo) lookupMojo("announcement-generate", pom);
+        AnnouncementMojo mojo = lookupMojo("announcement-generate", pom);
 
         setVariableValueToObject(mojo, "xmlPath", new File(getBasedir(), "/src/test/unit/announce-changes.xml"));
 
diff --git a/src/test/java/org/apache/maven/plugins/changes/github/GitHubDownloaderTest.java b/src/test/java/org/apache/maven/plugins/changes/github/GitHubDownloaderTest.java
index 04ea946..e8aae6b 100644
--- a/src/test/java/org/apache/maven/plugins/changes/github/GitHubDownloaderTest.java
+++ b/src/test/java/org/apache/maven/plugins/changes/github/GitHubDownloaderTest.java
@@ -29,7 +29,6 @@ import org.apache.maven.project.MavenProject;
 import org.apache.maven.settings.Server;
 import org.apache.maven.settings.Settings;
 import org.apache.maven.settings.building.DefaultSettingsProblem;
-import org.apache.maven.settings.building.SettingsProblem;
 import org.apache.maven.settings.building.SettingsProblem.Severity;
 import org.apache.maven.settings.crypto.DefaultSettingsDecryptionRequest;
 import org.apache.maven.settings.crypto.SettingsDecrypter;
@@ -82,7 +81,7 @@ public class GitHubDownloaderTest {
         SettingsDecryptionResult result = mock(SettingsDecryptionResult.class);
         Log log = mock(Log.class);
         when(result.getProblems())
-                .thenReturn(Collections.<SettingsProblem>singletonList(
+                .thenReturn(Collections.singletonList(
                         new DefaultSettingsProblem("Ups " + server.getId(), Severity.ERROR, null, -1, -1, null)));
         when(result.getServer()).thenReturn(server);
         when(decrypter.decrypt(any(SettingsDecryptionRequest.class))).thenReturn(result);
@@ -107,7 +106,7 @@ public class GitHubDownloaderTest {
         SettingsDecrypter decrypter = mock(SettingsDecrypter.class);
         SettingsDecryptionResult result = mock(SettingsDecryptionResult.class);
         Log log = mock(Log.class);
-        when(result.getProblems()).thenReturn(Collections.<SettingsProblem>emptyList());
+        when(result.getProblems()).thenReturn(Collections.emptyList());
         when(result.getServer()).thenReturn(server);
         when(decrypter.decrypt(new DefaultSettingsDecryptionRequest(server))).thenReturn(result);