You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@milagro.apache.org by "kealan (via GitHub)" <gi...@apache.org> on 2023/02/27 12:35:52 UTC
[GitHub] [incubator-milagro-crypto-c] kealan opened a new issue, #101: Only support 64 bit architecture
kealan opened a new issue, #101:
URL: https://github.com/apache/incubator-milagro-crypto-c/issues/101
## Goal
In order to simplify the project it is proposed to only build and test
for 64 bit architectures. The code that refers to 32 bit and 16 bit will
be commented out.
## Resources
## Acceptance criteria
1. Code is commented
2. Tests pass with more than 80% test coverage
3. Static analysis should pass
4. Code should be reviewed by two engineers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org
[GitHub] [incubator-milagro-crypto-c] kealan commented on issue #101: Only support 64 bit architecture
Posted by "kealan (via GitHub)" <gi...@apache.org>.
kealan commented on issue #101:
URL: https://github.com/apache/incubator-milagro-crypto-c/issues/101#issuecomment-1446443118
Hi Giorgio That is a fair point. I will just remove the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org
[GitHub] [incubator-milagro-crypto-c] giorgiozoppi commented on issue #101: Only support 64 bit architecture
Posted by "giorgiozoppi (via GitHub)" <gi...@apache.org>.
giorgiozoppi commented on issue #101:
URL: https://github.com/apache/incubator-milagro-crypto-c/issues/101#issuecomment-1484224856
Have you closed this? Is there any PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org
[GitHub] [incubator-milagro-crypto-c] giorgiozoppi commented on issue #101: Only support 64 bit architecture
Posted by "giorgiozoppi (via GitHub)" <gi...@apache.org>.
giorgiozoppi commented on issue #101:
URL: https://github.com/apache/incubator-milagro-crypto-c/issues/101#issuecomment-1446380448
@kealan commented code in the repo is bad pratice. I would rather prefer to remove the code that it's not related. I would rather tag (i.e. LAST_SUPPORT_32_BIT) and then remove all the code will no longer supported. Today i am in Dublin at we work docklands, if you wanna meet and test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org