You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by mi...@apache.org on 2019/04/10 02:22:18 UTC

[incubator-dubbo-admin] branch 0.2.0-release updated: remove node-notifier

This is an automated email from the ASF dual-hosted git repository.

min pushed a commit to branch 0.2.0-release
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-admin.git


The following commit(s) were added to refs/heads/0.2.0-release by this push:
     new f314c8e  remove node-notifier
f314c8e is described below

commit f314c8e004d1659418c472351f01ba999cfa356a
Author: nzomkxia <z8...@gmail.com>
AuthorDate: Wed Apr 10 10:22:05 2019 +0800

    remove node-notifier
---
 dubbo-admin-ui/build/utils.js | 17 -----------------
 dubbo-admin-ui/package.json   |  1 -
 2 files changed, 18 deletions(-)

diff --git a/dubbo-admin-ui/build/utils.js b/dubbo-admin-ui/build/utils.js
index 94f4200..2b70d5d 100644
--- a/dubbo-admin-ui/build/utils.js
+++ b/dubbo-admin-ui/build/utils.js
@@ -99,20 +99,3 @@ exports.styleLoaders = function (options) {
   return output
 }
 
-exports.createNotifierCallback = () => {
-  const notifier = require('node-notifier')
-
-  return (severity, errors) => {
-    if (severity !== 'error') return
-
-    const error = errors[0]
-    const filename = error.file && error.file.split('!').pop()
-
-    notifier.notify({
-      title: packageConfig.name,
-      message: severity + ': ' + error.name,
-      subtitle: filename || '',
-      icon: path.join(__dirname, 'logo.png')
-    })
-  }
-}
diff --git a/dubbo-admin-ui/package.json b/dubbo-admin-ui/package.json
index ed9a87b..19256d6 100644
--- a/dubbo-admin-ui/package.json
+++ b/dubbo-admin-ui/package.json
@@ -51,7 +51,6 @@
     "file-loader": "^1.1.4",
     "friendly-errors-webpack-plugin": "^1.6.1",
     "html-webpack-plugin": "^2.30.1",
-    "node-notifier": "^5.1.2",
     "optimize-css-assets-webpack-plugin": "^3.2.0",
     "ora": "^1.2.0",
     "portfinder": "^1.0.13",