You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/13 23:25:50 UTC

[GitHub] [airflow] mik-laj opened a new issue #12357: JSON schema validation for airflow/config_templates/config.yml

mik-laj opened a new issue #12357:
URL: https://github.com/apache/airflow/issues/12357


   Hello my friends,
   
   I hope you are all right and you are all healthy. Today I come with another small improvement proposal for our project. 
   
   I think it is worth adding JSON schema validations for `[airflow/config_templates/config.yml`](https://github.com/apache/airflow/blob/master/airflow/config_templates/config.yml) file. This will allow us to detect the wrong structure of this file very quickly and also provide simple documentation for this file. This schema should be verified every time a file is loaded.
   
   In order to generate a schema, you can use generators:
   https://onlineyamltools.com/convert-yaml-to-json
   https://www.liquid-technologies.com/online-json-to-schema-converter (Please note that you should set array rules to "List validation". In the result, it is also worth updating the JSON Schema specification versions to latest current spec)
   
   In the generated specification, it is worth adding descriptions for each field: 
   https://json-schema.org/understanding-json-schema/reference/generic.html#annotations
   
   Best regards,
   Kamil BreguΕ‚a
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] SamWheating commented on issue #12357: JSON schema validation for airflow/config_templates/config.yml

Posted by GitBox <gi...@apache.org>.
SamWheating commented on issue #12357:
URL: https://github.com/apache/airflow/issues/12357#issuecomment-739019278


   I can take this, but it may take me a week or two to get around to it. If that timeline is acceptable, then feel free to assign to me. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on issue #12357: JSON schema validation for airflow/config_templates/config.yml

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #12357:
URL: https://github.com/apache/airflow/issues/12357#issuecomment-739015113


   @SamWheating  Is it something interesting for you?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #12357: JSON schema validation for airflow/config_templates/config.yml

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #12357:
URL: https://github.com/apache/airflow/issues/12357#issuecomment-760107461


   Fixed in https://github.com/apache/airflow/pull/13025


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal closed issue #12357: JSON schema validation for airflow/config_templates/config.yml

Posted by GitBox <gi...@apache.org>.
eladkal closed issue #12357:
URL: https://github.com/apache/airflow/issues/12357


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj edited a comment on issue #12357: JSON schema validation for airflow/config_templates/config.yml

Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #12357:
URL: https://github.com/apache/airflow/issues/12357#issuecomment-739020214


   @SamWheating  This is not an urgent task, but we've been making some more changes lately. and I don't want to see bugs in this file, and w I assigned you to this ticket. πŸˆβ€β¬›πŸˆ


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on issue #12357: JSON schema validation for airflow/config_templates/config.yml

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #12357:
URL: https://github.com/apache/airflow/issues/12357#issuecomment-739020214


   @SamWheating  This is not an urgent task, but I don't want to see bugs in this file, and we've been making some more changes lately. I assigned you to this ticket. πŸˆβ€β¬›πŸˆ


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org