[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1314: MINIFICPP-1808 Improve RawSocketProtocol authorization error logging

[GitBox <gi...@apache.org>]

adam-markovics commented on code in PR #1314:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1314#discussion_r856315142


##########
libminifi/src/sitetosite/RawSocketProtocol.cpp:
##########
@@ -240,6 +240,12 @@ bool RawSiteToSiteClient::initiateCodecResourceNegotiation() {
   }
 }
 
+namespace {
+void logPortStateError(std::shared_ptr<core::logging::Logger>& logger, utils::Identifier port_id, const std::string& error) {

Review Comment:
   It's a dilemma to me. If it's a lambda, it has to be stored in a variable, that is allocated every time the function runs. Not a big performance issue BTW.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org