[jira] [Commented] (HBASE-15789) PB related changes to work with offheap

["Anoop Sam John (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552755#comment-15552755 ] 

Anoop Sam John commented on HBASE-15789:
----------------------------------------

We have moved to PB 3.1 now with shading in place. And now the src code is checked into our repo. 
CIS is already refactored to add new new input typed CIS.  PB already having byte[] based, IS based and DBB based CIS.  But we would need a new one.  We have a fixed sized DBB pool at RPC layer.  Right now only response sending use this (To make CellBlock).   On reading request into RpcServer, we make on demand temp byte[]s of size equal to request size. The idea there is to use the BBPool in this area as well.  So we will be reading the request bytes into 1+ BBs.   Said that we have to make a CIS on top of N DBBs.  We have an abstraction, ByteBuff, in place to handle N BBs.   
This jira will make necessary addition in PB code.  In COS we can see an interface ByteOutput and COS based on this.  Same way, we will add a ByteInput interface and a CIS based on that.  (More details when attaching a patch).  When we have to make CIS instance in RpcServer, we can impl ByteInput as a wrapper over the ByteBuff.


> PB related changes to work with offheap
> ---------------------------------------
>
>                 Key: HBASE-15789
>                 URL: https://issues.apache.org/jira/browse/HBASE-15789
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>
> This is an issue to brainstorm. Whether we go with pb 2.x or pb 3.0 and also depends on the shading of protobuf classes. 
> We should also decide if we are going to fork the PB classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)