You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2025/08/14 15:25:54 UTC
[PR] feat: Add config option to log fallback reasons [datafusion-comet]
andygrove opened a new pull request, #2154:
URL: https://github.com/apache/datafusion-comet/pull/2154
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes https://github.com/apache/datafusion-comet/issues/2134
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
See https://github.com/apache/datafusion-comet/issues/2134 for rationale.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add config option to log fallback reasons [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #2154:
URL: https://github.com/apache/datafusion-comet/pull/2154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add config option to log fallback reasons [datafusion-comet]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2154:
URL: https://github.com/apache/datafusion-comet/pull/2154#issuecomment-3189035731
## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/2154?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `9.75610%` with `37 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 34.83%. Comparing base ([`f09f8af`](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`28a9f5a`](https://app.codecov.io/gh/apache/datafusion-comet/commit/28a9f5a85a6e808595bc6725782297bc2a817f54?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 385 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion-comet/pull/2154?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../scala/org/apache/comet/serde/QueryPlanSerde.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/2154?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fcomet%2Fserde%2FQueryPlanSerde.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9jb21ldC9zZXJkZS9RdWVyeVBsYW5TZXJkZS5zY2FsYQ==) | 0.00% | [31 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/comet/CometSparkSessionExtensions.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/2154?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fcomet%2FCometSparkSessionExtensions.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9jb21ldC9Db21ldFNwYXJrU2Vzc2lvbkV4dGVuc2lvbnMuc2NhbGE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2154 +/- ##
=============================================
- Coverage 56.12% 34.83% -21.30%
+ Complexity 976 859 -117
=============================================
Files 119 143 +24
Lines 11743 13207 +1464
Branches 2251 2357 +106
=============================================
- Hits 6591 4600 -1991
- Misses 4012 7699 +3687
+ Partials 1140 908 -232
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/2154?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add config option to log fallback reasons [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #2154:
URL: https://github.com/apache/datafusion-comet/pull/2154#issuecomment-3201266406
Example output:
```
$ grep accelerate /tmp/tpch.log | awk '{print substr($0, 19)}' | sort | uniq
WARN CometSparkSessionExtensions: Comet cannot accelerate AdaptiveSparkPlanExec because: AdaptiveSparkPlan is not supported
WARN CometSparkSessionExtensions: Comet cannot accelerate AggregateExpression because: distinct aggregates are not supported
WARN CometSparkSessionExtensions: Comet cannot accelerate BroadcastHashJoinExec because: BuildRight with LeftAnti is not supported
WARN CometSparkSessionExtensions: Comet cannot accelerate BroadcastQueryStageExec because: BroadcastQueryStage is not supported
WARN CometSparkSessionExtensions: Comet cannot accelerate CommandResultExec because: CommandResult is not supported
WARN CometSparkSessionExtensions: Comet cannot accelerate ExecutedCommandExec because: Execute CreateViewCommand is not supported
WARN CometSparkSessionExtensions: Comet cannot accelerate ExecutedCommandExec because: Execute DropTempViewCommand is not supported
WARN CometSparkSessionExtensions: Comet cannot accelerate LocalTableScanExec because: LocalTableScan is not supported
WARN CometSparkSessionExtensions: Comet cannot accelerate ShuffleExchangeExec because: Child org.apache.spark.sql.execution.aggregate.HashAggregateExec is not native
WARN CometSparkSessionExtensions: Comet cannot accelerate ShuffleExchangeExec because: Child org.apache.spark.sql.execution.joins.BroadcastHashJoinExec is not native
WARN CometSparkSessionExtensions: Comet cannot accelerate ShuffleExchangeExec because: unsupported Spark partitioning: ArrayBuffer(custdist#385L DESC NULLS LAST, c_count#390L DESC NULLS LAST)
WARN CometSparkSessionExtensions: Comet cannot accelerate ShuffleExchangeExec because: unsupported Spark partitioning: ArrayBuffer(l_returnflag#24 ASC NULLS FIRST, l_linestatus#25 ASC NULLS FIRST)
WARN CometSparkSessionExtensions: Comet cannot accelerate ShuffleExchangeExec because: unsupported Spark partitioning: ArrayBuffer(l_shipmode#30 ASC NULLS FIRST)
WARN CometSparkSessionExtensions: Comet cannot accelerate ShuffleExchangeExec because: unsupported Spark partitioning: ArrayBuffer(nation#310 ASC NULLS FIRST, o_year#311 DESC NULLS LAST)
WARN CometSparkSessionExtensions: Comet cannot accelerate ShuffleExchangeExec because: unsupported Spark partitioning: ArrayBuffer(o_orderpriority#61 ASC NULLS FIRST)
WARN CometSparkSessionExtensions: Comet cannot accelerate ShuffleExchangeExec because: unsupported Spark partitioning: ArrayBuffer(o_year#282 ASC NULLS FIRST)
WARN CometSparkSessionExtensions: Comet cannot accelerate ShuffleExchangeExec because: unsupported Spark partitioning: ArrayBuffer(revenue#227 DESC NULLS LAST)
WARN CometSparkSessionExtensions: Comet cannot accelerate ShuffleExchangeExec because: unsupported Spark partitioning: ArrayBuffer(s_name#109 ASC NULLS FIRST)
WARN CometSparkSessionExtensions: Comet cannot accelerate ShuffleExchangeExec because: unsupported Spark partitioning: ArrayBuffer(s_suppkey#108L ASC NULLS FIRST)
WARN CometSparkSessionExtensions: Comet cannot accelerate ShuffleExchangeExec because: unsupported Spark partitioning: ArrayBuffer(supp_nation#250 ASC NULLS FIRST, cust_nation#251 ASC NULLS FIRST, l_year#252 ASC NULLS FIRST)
WARN CometSparkSessionExtensions: Comet cannot accelerate ShuffleExchangeExec because: unsupported Spark partitioning: ArrayBuffer(value#336 DESC NULLS LAST)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add config option to log fallback reasons [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #2154:
URL: https://github.com/apache/datafusion-comet/pull/2154#issuecomment-3201554300
Thanks for the review @mbutrovich
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add config option to log fallback reasons [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #2154:
URL: https://github.com/apache/datafusion-comet/pull/2154#discussion_r2285426260
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -207,8 +203,7 @@ object QueryPlanSerde extends Logging with CometExprShim {
supportedDataType(a.elementType, allowComplex)
case m: MapType if allowComplex =>
supportedDataType(m.keyType, allowComplex) && supportedDataType(m.valueType, allowComplex)
- case dt =>
- emitWarning(s"unsupported Spark data type: $dt")
Review Comment:
Callers of `supportedDataType` now call `withInfo` to record the fallback reason
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org