You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Boon Low (JIRA)" <ji...@apache.org> on 2014/12/31 13:05:13 UTC
[jira] [Comment Edited] (LUCENE-6149) Infix suggesters'
highlighting, allTermsRequired options are hardwired and not configurable
for non-contextual lookup
[ https://issues.apache.org/jira/browse/LUCENE-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262127#comment-14262127 ]
Boon Low edited comment on LUCENE-6149 at 12/31/14 12:04 PM:
-------------------------------------------------------------
Patch attached, + a couple of unit tests for allTermsRequired=false
was (Author: boonious):
Patch attached, + a couple of unit tests for allTermsReuqired=false
> Infix suggesters' highlighting, allTermsRequired options are hardwired and not configurable for non-contextual lookup
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-6149
> URL: https://issues.apache.org/jira/browse/LUCENE-6149
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/other
> Affects Versions: 4.9, 4.10.1, 4.10.2, 4.10.3
> Reporter: Boon Low
> Priority: Minor
> Labels: suggester
> Fix For: Trunk, 5.x
>
> Attachments: LUCENE-6149.patch
>
>
> Highlighting and allTermsRequired are hardwired in _AnalyzingInfixSuggester_ for non-contextual lookup (via _Lookup_) see *true*, *true* below:
> {code:title=AnalyzingInfixSuggester.java (extends Lookup.java) }
> public List<LookupResult> lookup(CharSequence key, Set<BytesRef> contexts, boolean onlyMorePopular, int num) throws IOException {
> return lookup(key, contexts, num, true, true);
> }
> /** Lookup, without any context. */
> public List<LookupResult> lookup(CharSequence key, int num, boolean allTermsRequired, boolean doHighlight) throws IOException {
> return lookup(key, null, num, allTermsRequired, doHighlight);
> }
> {code}
> {code:title=Lookup.java}
> public List<LookupResult> lookup(CharSequence key, boolean onlyMorePopular, int num) throws IOException {
> return lookup(key, null, onlyMorePopular, num);
> }
> {code}
> The above means the majority of current infix suggester lookup always returns highlighted results with allTermsRequired in effect, despite the options and improvement of LUCENE-6050, made to incorporate Boolean lookup clauses (MUST/SHOULD). This shortcoming has been reported in SOLR-6648.
> The suggesters (AnalyzingInfixSuggester, BlendedInfixSuggester) should provide proper default settings for highlighting and "allTermsRequired", so that these can be specified in constructors (+ in Solr factories and thus configurable via solrconfig.xml).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org