[jira] [Commented] (SOLR-6100) BlendedInfixSuggester and AnalyzingInfixSuggester are never closed on core shutdown (unremovable files on Windows)

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004435#comment-14004435 ] 

ASF subversion and git services commented on SOLR-6100:
-------------------------------------------------------

Commit 1596497 from [~dawidweiss] in branch 'dev/branches/lucene5650'
[ https://svn.apache.org/r1596497 ]

SOLR-6100, LUCENE-5650: fix an uncloseable file leak in solr suggesters.

> BlendedInfixSuggester and AnalyzingInfixSuggester are never closed on core shutdown (unremovable files on Windows)
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-6100
>                 URL: https://issues.apache.org/jira/browse/SOLR-6100
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.9, 5.0
>
>         Attachments: SOLR-6100.patch
>
>
> In essense these classes are Closeable but neither SolrSuggester nor Suggester close them at the core shutdown time.
> I'm also not sure what the difference is between SolrSuggester and Suggester and whether both or them are needed. They seem awfully similar...
> I've fixed the problem with the attached patch on LUCENE-5650, but I'd appreciate if somebody with a deeper knowledge of Solr could chime in and confirm the patch is all right.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org