Re: Review Request 14039: List modules instead of using package=['.']

[Niklas Nielsen <ni...@qni.dk>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14039/#review84918
-----------------------------------------------------------


We have ''packages': [ 'mesos' ],' in src/python/setup.py.in - do we need mesos_pb2?

- Niklas Nielsen


On Sept. 9, 2013, 12:22 p.m., Jason Dusek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14039/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2013, 12:22 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> List modules instead of using package=['.']
> 
> Using packages= without an __init__.py is recommended against in the docs and
> happens to break FPM. From the python.org documentation:
> 
>   The packages option tells the Distutils to process (build, distribute,
>   install, etc.) all pure Python modules found in each package mentioned in
>   the packages list. In order to do this, of course, there has to be a
>   correspondence between package names and directories in the filesystem. The
>   default correspondence is the most obvious one, i.e. package distutils is
>   found in the directory distutils relative to the distribution root. Thus,
>   when you say packages = ['foo'] in your setup script, you are promising that
>   the Distutils will find a file foo/__init__.py (which might be spelled
>   differently on your system, but you get the idea) relative to the directory
>   where your setup script lives. If you break this promise, the Distutils will
>   issue a warning but still process the broken package anyway.
> 
> http://docs.python.org/2/distutils/setupscript.html#listing-whole-packages
> 
> Review: http://reviews.apache.org/r/14039
> 
> 
> Diffs
> -----
> 
>   src/python/setup.py.in 77fa880a16f1c8ccecb7bb0db3cfea75413b104a 
> 
> Diff: https://reviews.apache.org/r/14039/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Dusek
> 
>