You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/12 18:04:40 UTC

[GitHub] [kafka] vvcephei commented on a change in pull request #10119: Kip 695 revert

vvcephei commented on a change in pull request #10119:
URL: https://github.com/apache/kafka/pull/10119#discussion_r575413056



##########
File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
##########
@@ -144,7 +144,6 @@
     private static final long EOS_DEFAULT_COMMIT_INTERVAL_MS = 100L;
 
     public static final int DUMMY_THREAD_INDEX = 1;

Review comment:
       Thanks, @chia7712 .
   
   Are you pointing out that this doesn't completely revert the commits? This is true. I had to resolve a bunch of conflicts anyway, so I went over the diff and kept most of the "code cleanup" changes that I had done in those commits. That way, code in 2.8 will be as close as possible to trunk, making it easier to cherry-pick fixes in the future.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org