Re: SingleThreadedPool.java

[Peter Donald <do...@apache.org>]

On Fri, 31 Aug 2001 04:46, Corey O'Donovan wrote:
> Hi,
>
> First off, I'm fairly new to Ant and jUnit so I've been unable to run the
> testcase org.apache.avalon.excalibur.pool.test.PoolProfile which I believe
> tests SingleThreadedPool.
> "build.bat" test doesn't seem to run the test either.

The current CVS version requires you to do something like

build.bat -Dtest.profile=true test-report 

while the last released version requires you to do

build.bat -Dtest.profile=true test

> I've encountered a problem with the SingleThreadedPool in that it
> alternatley returns valid and null pooled objects until you've got the
> "initial" constructor argument + 1 and then it starts returning
> (Poolable)m_factory.newInstance(). Does that make sense? This effect is
> only seen if you call a method on the object returned from the pool. The
> PoolProfile class simply "get"s from the pool and then "put"s into the
> pool. If methods were added to the static classes inside PoolProfile and
> PoolProfile were to call these methods between gets and puts I think this
> could be demonstrated. I've attached a patch for SingleThreadedPool that I
> believe fixes this.

Looks good ... Berin - look good to you ?

-- 
Cheers,

Pete

*------------------------------------------------*
| You can't wake a person who is pretending      |
|       to be asleep. -Navajo Proverb.           |
*------------------------------------------------*

---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org