You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "lordgamez (via GitHub)" <gi...@apache.org> on 2026/05/05 11:26:18 UTC
[PR] MINIFICPP-2802 Pre-pull docker images for extension tests [nifi-minifi-cpp]
lordgamez opened a new pull request, #2169:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2169
Avoid issues if docker image pull is slow and that would interfere while running the test scenario.
https://issues.apache.org/jira/browse/MINIFICPP-2802
-------------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2802 Pre-pull docker images for extension tests [nifi-minifi-cpp]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2169:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2169#discussion_r3194483400
##########
extensions/splunk/tests/features/environment.py:
##########
@@ -14,11 +14,17 @@
# limitations under the License.
import platform
+import docker
+from containers.splunk_container import SplunkContainer
from minifi_behave.core.hooks import common_before_scenario
from minifi_behave.core.hooks import common_after_scenario
+def before_all(context):
+ docker.from_env().images.pull(SplunkContainer.IMAGE)
+
Review Comment:
`before_all` pulls the Splunk image unconditionally, but this test suite already skips `x86_x64_only` features in `before_feature`. On non-x86 platforms this will still attempt to pull an image that may be unavailable/incompatible and can fail the run before the skip happens. Consider moving the pull into `before_feature` (after the architecture check) or guarding the pull with the same `is_x86` condition / feature tag check so skipped features don’t trigger image pulls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2802 Pre-pull docker images for extension tests [nifi-minifi-cpp]
Posted by "martinzink (via GitHub)" <gi...@apache.org>.
martinzink merged PR #2169:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2802 Pre-pull docker images for extension tests [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #2169:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2169#discussion_r3194505481
##########
extensions/splunk/tests/features/environment.py:
##########
@@ -14,11 +14,17 @@
# limitations under the License.
import platform
+import docker
+from containers.splunk_container import SplunkContainer
from minifi_behave.core.hooks import common_before_scenario
from minifi_behave.core.hooks import common_after_scenario
+def before_all(context):
+ docker.from_env().images.pull(SplunkContainer.IMAGE)
+
Review Comment:
Updated in https://github.com/apache/nifi-minifi-cpp/pull/2169/commits/06f9085d89f6898a9a67286534746e5aee6a867f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org