[GitHub] [lucene-solr] thelabdude commented on a change in pull request #2346: SOLR-15145: System property to control whether base_url is stored in state.json to enable back-compat with older SolrJ versions

[GitBox <gi...@apache.org>]

thelabdude commented on a change in pull request #2346:
URL: https://github.com/apache/lucene-solr/pull/2346#discussion_r573910079



##########
File path: solr/CHANGES.txt
##########
@@ -4,6 +4,14 @@ This file lists Solr's raw release notes with details of every change to Solr.
 Most people will find the solr-upgrade-notes.adoc file more approachable.
 https://github.com/apache/lucene-solr/blob/master/solr/solr-ref-guide/src/solr-upgrade-notes.adoc
 
+==================  8.8.1 ==================

Review comment:
       The property already defaults to true, which means the `base_url` will be stored again, so really there's nothing people need to do with the sys prop to get an older SolrJ to work with an 8.8.1 server again. In reality, the sys prop is only there for people that are running the latest SolrJ and want to prepare their clusters for 9.x by explicitly setting to `false`. Doubt anyone will actually do that so the sys prop is probably not all that useful.
   
   I still need to test to make sure an upgrade of server nodes from 8.8.0 to 8.8.1 does restore the `base_url` in ZK.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org