[GitHub] [maven-resources-plugin] rmannibucau commented on a change in pull request #5: try with resources

[GitBox <gi...@apache.org>]

rmannibucau commented on a change in pull request #5:
URL: https://github.com/apache/maven-resources-plugin/pull/5#discussion_r456447966



##########
File path: src/test/java/org/apache/maven/plugins/resources/stub/MavenProjectBuildStub.java
##########
@@ -300,8 +293,6 @@ private void populateFile( File file ) throws IOException
             try ( FileOutputStream outputStream = new FileOutputStream( file ) )
             {
                 outputStream.write( data.getBytes() );
-                outputStream.flush();

Review comment:
       Calling flush just before close is generally useless cause close ensures all data have been written.
   That said we are speaking of a FileOutputStream where flush() is a noop so it is even safer to drop.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org