You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mikebridge (via GitHub)" <gi...@apache.org> on 2026/06/17 17:18:04 UTC
[PR] feat(soft-delete): gate soft delete behind a temporary SOFT_DELETE flag [superset]
mikebridge opened a new pull request, #41166:
URL: https://github.com/apache/superset/pull/41166
### SUMMARY
Adds a **temporary** rollout / kill-switch feature flag — `SOFT_DELETE` (default **off**) — so the soft-delete substrate can ship **dark** and be activated per-deploy once validated, separating deploy from release for a behavior change with cross-entity blast radius (DELETE semantics + read-path visibility filtering).
This is **deployment scaffolding, not a permanent toggle**: it is removed once soft delete is stable, leaving the unconditional "always active once deployed" end state. Until an operator opts in, existing deployments retain byte-for-byte legacy `DELETE` (hard-delete) behavior.
**Two gate points**, both no-op to legacy behavior when off:
- `BaseDAO.delete()` routes to `soft_delete()` only when the flag is on; otherwise `hard_delete()`.
- The `do_orm_execute` visibility listener attaches no `deleted_at IS NULL` criteria when off.
Both the write path and the read path gate on the **same flag**, so they cannot diverge. Restore needs no explicit gate — with the flag off no row carries `deleted_at`, so a restore call has nothing to act on. The flag docstring documents the kill-switch semantics (flipping **off after** rows are soft-deleted resurrects them — emergency stop, not a clean rollback) and that the import pipeline's existing-row detection is gated transitively via the listener.
The `deleted_at` migration (from the substrate PRs) stays **un-gated** (additive). Removal of this flag + its two gate points is a small follow-up once soaked.
### TESTING INSTRUCTIONS
Unit tests cover both flag states (default-off and on):
```
pytest tests/unit_tests/daos/test_base_dao_soft_delete.py \
tests/unit_tests/models/test_soft_delete_mixin.py
```
- With `FEATURE_FLAGS = {"SOFT_DELETE": False}` (default): a `DELETE` on a `SoftDeleteMixin` model hard-deletes, and the read-path listener does not hide soft-deleted rows.
- With `SOFT_DELETE` on: `DELETE` soft-deletes and the listener filters soft-deleted rows out of reads (existing substrate behavior).
### ADDITIONAL INFORMATION
- [x] Required feature flags: **`SOFT_DELETE`** (default off; temporary rollout/kill-switch — to be removed after stabilization)
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): gate soft delete behind a temporary SOFT_DELETE flag [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41166:
URL: https://github.com/apache/superset/pull/41166#issuecomment-4734985599
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): gate soft delete behind a temporary SOFT_DELETE release toggle [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #41166:
URL: https://github.com/apache/superset/pull/41166#issuecomment-4835312180
The PR itself seems fine, but this might warrant some discussion with other orgs, like @michael-s-molina / @villebro
The SIP already approved the feature, so we COULD just go full-launch during the 7.0 breaking window, I would think. If we add this flag during the 7.0 cycle, we probably can't change/remove it until 8.0, so I'm not sure if we want that overhead or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): gate soft delete behind a temporary SOFT_DELETE release toggle [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #41166:
URL: https://github.com/apache/superset/pull/41166#discussion_r3500126788
##########
tests/unit_tests/models/test_soft_delete_mixin.py:
##########
@@ -167,6 +180,31 @@ def test_global_filter_excludes_soft_deleted_rows(
assert result is None
+@pytest.mark.usefixtures("_synthetic_tables")
+def test_listener_noop_when_gate_off(app_context: None, session: Session) -> None:
+ """With the ``SOFT_DELETE`` gate OFF, the listener attaches no criteria, so a
+ soft-deleted row is NOT hidden — the substrate is dark. (While
+ the gate is off the delete path also doesn't create such rows; this pins the
+ listener side.)"""
+ obj = _SoftDeletable(name="visible_when_gate_off")
Review Comment:
**Suggestion:** Add an explicit type annotation for this newly introduced local variable to comply with the type-hint requirement. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is newly added Python code and the local variable `obj` is not type-annotated even though its type is clear from the constructor call, so it matches the rule requiring type hints on relevant variables.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=8197f7c800734b4ebb2e87ec1632372a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=8197f7c800734b4ebb2e87ec1632372a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/models/test_soft_delete_mixin.py
**Line:** 189:189
**Comment:**
*Custom Rule: Add an explicit type annotation for this newly introduced local variable to comply with the type-hint requirement.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41166&comment_hash=00b80bce2100f1842564940d88ab10ae2a40dd3529b8defc20e031362e924d46&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41166&comment_hash=00b80bce2100f1842564940d88ab10ae2a40dd3529b8defc20e031362e924d46&reaction=dislike'>👎</a>
##########
tests/unit_tests/daos/test_base_dao_soft_delete.py:
##########
@@ -59,17 +59,37 @@ class _PlainDAO(BaseDAO[_Plain]):
model_cls = _Plain
-def test_delete_routes_to_soft_delete_for_mixin_models(app_context: None) -> None:
- """delete() calls soft_delete() when model_cls includes SoftDeleteMixin."""
+@patch("superset.daos.base.is_feature_enabled", return_value=True)
+def test_delete_routes_to_soft_delete_for_mixin_models(
+ mock_flag: MagicMock, app_context: None
+) -> None:
+ """delete() soft-deletes a mixin model when the SOFT_DELETE gate is ON."""
items = [MagicMock(), MagicMock()]
Review Comment:
**Suggestion:** Add an explicit type annotation for the local collection variable so the new test code follows the required typing rule for annotatable variables. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The added test introduces a new local variable that can be annotated as a collection type, but it is left untyped. This matches the custom rule requiring type hints on relevant variables in new or modified Python code.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=c24d65b10f44401283f4d47d406696a6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=c24d65b10f44401283f4d47d406696a6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/daos/test_base_dao_soft_delete.py
**Line:** 67:67
**Comment:**
*Custom Rule: Add an explicit type annotation for the local collection variable so the new test code follows the required typing rule for annotatable variables.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41166&comment_hash=866d5271d6244579908c8567fe65cf86f0447f91a95b9a57036f9b3e92c75a47&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41166&comment_hash=866d5271d6244579908c8567fe65cf86f0447f91a95b9a57036f9b3e92c75a47&reaction=dislike'>👎</a>
##########
tests/unit_tests/models/test_soft_delete_mixin.py:
##########
@@ -167,6 +180,31 @@ def test_global_filter_excludes_soft_deleted_rows(
assert result is None
+@pytest.mark.usefixtures("_synthetic_tables")
+def test_listener_noop_when_gate_off(app_context: None, session: Session) -> None:
+ """With the ``SOFT_DELETE`` gate OFF, the listener attaches no criteria, so a
+ soft-deleted row is NOT hidden — the substrate is dark. (While
+ the gate is off the delete path also doesn't create such rows; this pins the
+ listener side.)"""
+ obj = _SoftDeletable(name="visible_when_gate_off")
+ session.add(obj)
+ session.flush()
+ obj_id = obj.id
+
+ obj.soft_delete()
+ session.flush()
+ session.expire_all()
+
+ with patch("superset.models.helpers.is_feature_enabled", return_value=False):
+ result = (
+ session.query(_SoftDeletable)
+ .filter(_SoftDeletable.id == obj_id)
+ .one_or_none()
+ )
Review Comment:
**Suggestion:** Annotate this query result variable with its expected optional model type to meet the type-hint rule for relevant variables. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The new query result variable `result` is left unannotated even though its optional model type is inferable, which fits the rule for annotating relevant Python variables.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=0b42ab80436c4657b434933a4b75b12c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=0b42ab80436c4657b434933a4b75b12c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/models/test_soft_delete_mixin.py
**Line:** 199:203
**Comment:**
*Custom Rule: Annotate this query result variable with its expected optional model type to meet the type-hint rule for relevant variables.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41166&comment_hash=8b9f9187a9eb658906e5a66ae87a10a3c69b36aa8aa70a10a696accc59e605bc&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41166&comment_hash=8b9f9187a9eb658906e5a66ae87a10a3c69b36aa8aa70a10a696accc59e605bc&reaction=dislike'>👎</a>
##########
tests/unit_tests/models/test_soft_delete_mixin.py:
##########
@@ -167,6 +180,31 @@ def test_global_filter_excludes_soft_deleted_rows(
assert result is None
+@pytest.mark.usefixtures("_synthetic_tables")
+def test_listener_noop_when_gate_off(app_context: None, session: Session) -> None:
+ """With the ``SOFT_DELETE`` gate OFF, the listener attaches no criteria, so a
+ soft-deleted row is NOT hidden — the substrate is dark. (While
+ the gate is off the delete path also doesn't create such rows; this pins the
+ listener side.)"""
+ obj = _SoftDeletable(name="visible_when_gate_off")
+ session.add(obj)
+ session.flush()
+ obj_id = obj.id
Review Comment:
**Suggestion:** Add a concrete type hint for this identifier value to satisfy the rule requiring annotations on relevant variables. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This added line introduces an unannotated local variable `obj_id` whose type can be annotated, so it violates the Python type-hint requirement.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=fd84748eefde4696b90def4953327e03&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=fd84748eefde4696b90def4953327e03&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/models/test_soft_delete_mixin.py
**Line:** 192:192
**Comment:**
*Custom Rule: Add a concrete type hint for this identifier value to satisfy the rule requiring annotations on relevant variables.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41166&comment_hash=b0eae144e44c4044f256f4362566228eacd054a64f35a9afef033a824d2b5297&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41166&comment_hash=b0eae144e44c4044f256f4362566228eacd054a64f35a9afef033a824d2b5297&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): gate soft delete behind a temporary SOFT_DELETE release toggle [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #41166:
URL: https://github.com/apache/superset/pull/41166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): gate soft delete behind a temporary SOFT_DELETE release toggle [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41166:
URL: https://github.com/apache/superset/pull/41166#issuecomment-4848476711
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): gate soft delete behind a temporary SOFT_DELETE release toggle [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on code in PR #41166:
URL: https://github.com/apache/superset/pull/41166#discussion_r3500300319
##########
docs/static/feature-flags.json:
##########
@@ -87,6 +87,12 @@
"lifecycle": "development",
"description": "Enable semantic layers and show semantic views alongside datasets"
},
+ {
+ "name": "SOFT_DELETE",
+ "default": false,
+ "lifecycle": "development",
+ "description": "Temporary rollout / kill-switch gate for soft delete. Default off. When off: DELETE hard-deletes (legacy) and the read-path visibility filter is inactive, so the substrate ships dark; the import pipeline's existing-row detection inherits this via the same listener (no separate check); restore has nothing to act on because no row carries deleted_at. Flipping ON->OFF after rows were soft-deleted RESURRECTS them (they become visible/active again) \u2014 an emergency stop, not a clean rollback. Not a permanent toggle: REMOVE this flag and its two gate points (BaseDAO.delete routing; the do_orm_execute visibility listener) once soft delete is stable."
Review Comment:
NIT: This description is ~360 characters — roughly 5× longer than neighboring entries (e.g., `"Enables Table V2 (AG Grid) viz plugin"`). The detail is valuable (resurrection risk, two gate points to remove), but documentation UIs may clip it. The verbose explanation already lives in `config.py`'s inline comment; a shorter flag description here pointing operators there might serve better.
##########
tests/unit_tests/daos/test_base_dao_soft_delete.py:
##########
@@ -59,17 +59,37 @@ class _PlainDAO(BaseDAO[_Plain]):
model_cls = _Plain
-def test_delete_routes_to_soft_delete_for_mixin_models(app_context: None) -> None:
- """delete() calls soft_delete() when model_cls includes SoftDeleteMixin."""
+@patch("superset.daos.base.is_feature_enabled", return_value=True)
+def test_delete_routes_to_soft_delete_for_mixin_models(
+ mock_flag: MagicMock, app_context: None
+) -> None:
+ """delete() soft-deletes a mixin model when the SOFT_DELETE gate is ON."""
items = [MagicMock(), MagicMock()]
with patch.object(_SoftDeletableDAO, "soft_delete") as mock_soft:
_SoftDeletableDAO.delete(items)
mock_soft.assert_called_once_with(items)
-def test_delete_routes_to_hard_delete_for_non_mixin_models(app_context: None) -> None:
- """delete() calls hard_delete() for non-SoftDeleteMixin models."""
+@patch("superset.daos.base.is_feature_enabled", return_value=False)
+def test_delete_hard_deletes_mixin_model_when_gate_off(
+ mock_flag: MagicMock, app_context: None
+) -> None:
+ """With the SOFT_DELETE gate OFF (default), even a mixin model hard-deletes
+ — the substrate ships dark."""
+ items = [MagicMock(), MagicMock()]
+
+ with patch.object(_SoftDeletableDAO, "hard_delete") as mock_hard:
+ _SoftDeletableDAO.delete(items)
+ mock_hard.assert_called_once_with(items)
+
+
+@patch("superset.daos.base.is_feature_enabled", return_value=True)
+def test_delete_routes_to_hard_delete_for_non_mixin_models(
Review Comment:
NIT: The test matrix covers 3 of the 4 `(gate, model_type)` combinations:
- gate=ON + SoftDeleteMixin → `soft_delete()` ✓
- gate=OFF + SoftDeleteMixin → `hard_delete()` ✓
- gate=ON + plain → `hard_delete()` ✓
- gate=OFF + plain → `hard_delete()` ✗
The fourth case is trivially implied — `issubclass(cls.model_cls, SoftDeleteMixin)` short-circuits to `False` before the gate is evaluated — but adding it explicitly means a future refactor of the `delete()` conditional is caught immediately. Consider adding a `test_delete_hard_deletes_plain_model_when_gate_off` alongside this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): gate soft delete behind a temporary SOFT_DELETE release toggle [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41166:
URL: https://github.com/apache/superset/pull/41166#issuecomment-4772854964
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): gate soft delete behind a temporary SOFT_DELETE flag [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41166:
URL: https://github.com/apache/superset/pull/41166#issuecomment-4733326154
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): gate soft delete behind a temporary SOFT_DELETE flag [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #41166:
URL: https://github.com/apache/superset/pull/41166#issuecomment-4733348335
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | e7edbc630b8e62ee628709ab420bb02ffe33abd5 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a32d6ccd062ed00084741a9 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-41166--superset-docs-preview.netlify.app](https://deploy-preview-41166--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#Dco7DoAgDADQu3S2SfkEPzfwGEirDigEWIzx7rK94b2QS7pygwVggK34O5zdNaBSShvCmvaGLFGa4OGb9MWSY3pW7s95o9mFwOS0MBFNdrTKz_D9) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-41166--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): gate soft delete behind a temporary SOFT_DELETE release toggle [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #41166:
URL: https://github.com/apache/superset/pull/41166#issuecomment-4835316780
...unless, of course, your plan is to also remove it during the 7.0 window and it's more temporary than I'm assuming here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): gate soft delete behind a temporary SOFT_DELETE release toggle [superset]
Posted by "mikebridge (via GitHub)" <gi...@apache.org>.
mikebridge commented on code in PR #41166:
URL: https://github.com/apache/superset/pull/41166#discussion_r3501388266
##########
tests/unit_tests/daos/test_base_dao_soft_delete.py:
##########
@@ -59,17 +59,37 @@ class _PlainDAO(BaseDAO[_Plain]):
model_cls = _Plain
-def test_delete_routes_to_soft_delete_for_mixin_models(app_context: None) -> None:
- """delete() calls soft_delete() when model_cls includes SoftDeleteMixin."""
+@patch("superset.daos.base.is_feature_enabled", return_value=True)
+def test_delete_routes_to_soft_delete_for_mixin_models(
+ mock_flag: MagicMock, app_context: None
+) -> None:
+ """delete() soft-deletes a mixin model when the SOFT_DELETE gate is ON."""
items = [MagicMock(), MagicMock()]
with patch.object(_SoftDeletableDAO, "soft_delete") as mock_soft:
_SoftDeletableDAO.delete(items)
mock_soft.assert_called_once_with(items)
-def test_delete_routes_to_hard_delete_for_non_mixin_models(app_context: None) -> None:
- """delete() calls hard_delete() for non-SoftDeleteMixin models."""
+@patch("superset.daos.base.is_feature_enabled", return_value=False)
+def test_delete_hard_deletes_mixin_model_when_gate_off(
+ mock_flag: MagicMock, app_context: None
+) -> None:
+ """With the SOFT_DELETE gate OFF (default), even a mixin model hard-deletes
+ — the substrate ships dark."""
+ items = [MagicMock(), MagicMock()]
+
+ with patch.object(_SoftDeletableDAO, "hard_delete") as mock_hard:
+ _SoftDeletableDAO.delete(items)
+ mock_hard.assert_called_once_with(items)
+
+
+@patch("superset.daos.base.is_feature_enabled", return_value=True)
+def test_delete_routes_to_hard_delete_for_non_mixin_models(
Review Comment:
Done in 8186348 — added `test_delete_hard_deletes_non_mixin_model_when_gate_off`, completing the 4th `(gate=OFF, plain)` cell of the matrix.
_— posted by Claude (AI agent) on behalf of @mikebridge_
##########
docs/static/feature-flags.json:
##########
@@ -87,6 +87,12 @@
"lifecycle": "development",
"description": "Enable semantic layers and show semantic views alongside datasets"
},
+ {
+ "name": "SOFT_DELETE",
+ "default": false,
+ "lifecycle": "development",
+ "description": "Temporary rollout / kill-switch gate for soft delete. Default off. When off: DELETE hard-deletes (legacy) and the read-path visibility filter is inactive, so the substrate ships dark; the import pipeline's existing-row detection inherits this via the same listener (no separate check); restore has nothing to act on because no row carries deleted_at. Flipping ON->OFF after rows were soft-deleted RESURRECTS them (they become visible/active again) \u2014 an emergency stop, not a clean rollback. Not a permanent toggle: REMOVE this flag and its two gate points (BaseDAO.delete routing; the do_orm_execute visibility listener) once soft delete is stable."
Review Comment:
Done in 8186348 — trimmed to ~290 chars (from ~660) and pointed operators to the `config.py` inline comment for the full rationale + gate points.
_— posted by Claude (AI agent) on behalf of @mikebridge_
##########
tests/unit_tests/daos/test_base_dao_soft_delete.py:
##########
@@ -59,17 +59,37 @@ class _PlainDAO(BaseDAO[_Plain]):
model_cls = _Plain
-def test_delete_routes_to_soft_delete_for_mixin_models(app_context: None) -> None:
- """delete() calls soft_delete() when model_cls includes SoftDeleteMixin."""
+@patch("superset.daos.base.is_feature_enabled", return_value=True)
+def test_delete_routes_to_soft_delete_for_mixin_models(
+ mock_flag: MagicMock, app_context: None
+) -> None:
+ """delete() soft-deletes a mixin model when the SOFT_DELETE gate is ON."""
items = [MagicMock(), MagicMock()]
Review Comment:
Done in 8186348 — annotated `items: list[MagicMock]`.
_— posted by Claude (AI agent) on behalf of @mikebridge_
##########
tests/unit_tests/models/test_soft_delete_mixin.py:
##########
@@ -167,6 +180,31 @@ def test_global_filter_excludes_soft_deleted_rows(
assert result is None
+@pytest.mark.usefixtures("_synthetic_tables")
+def test_listener_noop_when_gate_off(app_context: None, session: Session) -> None:
+ """With the ``SOFT_DELETE`` gate OFF, the listener attaches no criteria, so a
+ soft-deleted row is NOT hidden — the substrate is dark. (While
+ the gate is off the delete path also doesn't create such rows; this pins the
+ listener side.)"""
+ obj = _SoftDeletable(name="visible_when_gate_off")
Review Comment:
Done in 8186348 — annotated `obj: _SoftDeletable`.
_— posted by Claude (AI agent) on behalf of @mikebridge_
##########
tests/unit_tests/models/test_soft_delete_mixin.py:
##########
@@ -167,6 +180,31 @@ def test_global_filter_excludes_soft_deleted_rows(
assert result is None
+@pytest.mark.usefixtures("_synthetic_tables")
+def test_listener_noop_when_gate_off(app_context: None, session: Session) -> None:
+ """With the ``SOFT_DELETE`` gate OFF, the listener attaches no criteria, so a
+ soft-deleted row is NOT hidden — the substrate is dark. (While
+ the gate is off the delete path also doesn't create such rows; this pins the
+ listener side.)"""
+ obj = _SoftDeletable(name="visible_when_gate_off")
+ session.add(obj)
+ session.flush()
+ obj_id = obj.id
Review Comment:
Done in 8186348 — annotated `obj_id: int`.
_— posted by Claude (AI agent) on behalf of @mikebridge_
##########
tests/unit_tests/models/test_soft_delete_mixin.py:
##########
@@ -167,6 +180,31 @@ def test_global_filter_excludes_soft_deleted_rows(
assert result is None
+@pytest.mark.usefixtures("_synthetic_tables")
+def test_listener_noop_when_gate_off(app_context: None, session: Session) -> None:
+ """With the ``SOFT_DELETE`` gate OFF, the listener attaches no criteria, so a
+ soft-deleted row is NOT hidden — the substrate is dark. (While
+ the gate is off the delete path also doesn't create such rows; this pins the
+ listener side.)"""
+ obj = _SoftDeletable(name="visible_when_gate_off")
+ session.add(obj)
+ session.flush()
+ obj_id = obj.id
+
+ obj.soft_delete()
+ session.flush()
+ session.expire_all()
+
+ with patch("superset.models.helpers.is_feature_enabled", return_value=False):
+ result = (
+ session.query(_SoftDeletable)
+ .filter(_SoftDeletable.id == obj_id)
+ .one_or_none()
+ )
Review Comment:
Done in 8186348 — annotated `result: _SoftDeletable | None`.
_— posted by Claude (AI agent) on behalf of @mikebridge_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): gate soft delete behind a temporary SOFT_DELETE release toggle [superset]
Posted by "mikebridge (via GitHub)" <gi...@apache.org>.
mikebridge commented on PR #41166:
URL: https://github.com/apache/superset/pull/41166#issuecomment-4836947007
### Soft-delete rollout — related PRs & merge order
This is one of four coordinated PRs implementing soft-delete + restore per [SIP-208](https://github.com/apache/superset/issues/39464), on top of the merged infrastructure (#39977).
**Merge order matters** — the gate must land first so the entity PRs ship behind the `SOFT_DELETE` release toggle (default **off**). Merging an entity PR before the gate would ship soft-delete **unguarded**.
| Order | PR | Role |
|-------|-----|------|
| 1️⃣ | #41166 | `SOFT_DELETE` release toggle (the gate) — **merge first** ⬅︎ |
| 2️⃣ | #40129 | charts soft-delete + restore |
| 3️⃣ | #40128 | dashboards soft-delete + restore |
| 4️⃣ | #40130 | datasets soft-delete + restore |
After the gate merges, each entity PR is rebased onto the gated `master` and inherits the flag. Each entity migration's `down_revision` is currently `78a40c08b4be` (current master head) and is re-pointed at merge time as siblings land, to keep a single Alembic head.
The gate ← **this PR**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): gate soft delete behind a temporary SOFT_DELETE release toggle [superset]
Posted by "mikebridge (via GitHub)" <gi...@apache.org>.
mikebridge commented on PR #41166:
URL: https://github.com/apache/superset/pull/41166#issuecomment-4847223906
> ...unless, of course, your plan is to also remove it during the 7.0 window and it's more temporary than I'm assuming here.
>
> I get the difference between the release toggle and feature flag, but it seems like a fine line. If we're going to be releasing 7.0 with it off, and people are flipping it on in prod, with the intent that it becomes True by default in the next major and/or gets removed in 8.0, then it gets a bit muddy, no? I maybe misunderstanding, which is why it might just be worth a 5 minute chat :D
@rusackas Yes, the plan is to remove it entirely before the release, because we don't want two paths through the code, doubling the cyclomatic complexity (as per my initial discussion with Max---we just want the feature to be awesome). In my conception, it is totally orthogonal from a feature flag, because it's focused purely on the release, and not intended to give end users choices about functionality. My hope is: nobody ever flips it except me or QA. We *could* leave it in if we want a MTTR fallback but the best case scenario is that everything is stable enough that we don't need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(soft-delete): gate soft delete behind a temporary SOFT_DELETE flag [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #41166:
URL: https://github.com/apache/superset/pull/41166#issuecomment-4733571902
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/41166?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 63.54%. Comparing base ([`464c67d`](https://app.codecov.io/gh/apache/superset/commit/464c67d586895c4265139e44ea15899fc537db47?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`71bc1f2`](https://app.codecov.io/gh/apache/superset/commit/71bc1f23ae9b6100ebd3f0354a7b7ba2918ae067?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/41166?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset/daos/base.py](https://app.codecov.io/gh/apache/superset/pull/41166?src=pr&el=tree&filepath=superset%2Fdaos%2Fbase.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGFvcy9iYXNlLnB5) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/41166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #41166 +/- ##
==========================================
- Coverage 64.31% 63.54% -0.77%
==========================================
Files 2652 2652
Lines 144807 144808 +1
Branches 33423 33423
==========================================
- Hits 93126 92023 -1103
- Misses 50013 51114 +1101
- Partials 1668 1671 +3
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/41166/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/41166/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.32% <66.66%> (-0.01%)` | :arrow_down: |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/41166/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/41166/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/41166/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.89% <66.66%> (-0.01%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/41166/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.93% <66.66%> (-1.64%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/41166/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.77% <66.66%> (-0.02%)` | :arrow_down: |
| [unit](https://app.codecov.io/gh/apache/superset/pull/41166/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/41166?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org