You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2018/08/22 14:23:52 UTC
[GitHub] myrle-krantz commented on issue #20: Integrating the notification
service
myrle-krantz commented on issue #20: Integrating the notification service
URL: https://github.com/apache/fineract-cn-demo-server/pull/20#issuecomment-415049995
Looks good. I'd only like to ask for one change before I merge:
Please give the notification user and the password constants more specific names. e.g. USER_IDENTIFIER -> NOTIFICATION_USER_IDENTIFIER
Once you improve the application authentication code for accessing customer, you'll probably want to update this code again. But let's get this bit merged now anyways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services