You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/02/02 23:37:15 UTC
[GitHub] [helix] NealSun96 opened a new pull request #1627: Fix ZkAddress null case for TaskStateModelFactory
NealSun96 opened a new pull request #1627:
URL: https://github.com/apache/helix/pull/1627
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Fix #1626
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
If zkAddress is null for the HelixManager passed to TaskStateModelFactory and multizk is not enabled, a NullPointerException will be raised. This PR fixes that by adding a null check.
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 commented on pull request #1627: Fix ZkAddress null case for TaskStateModelFactory
Posted by GitBox <gi...@apache.org>.
NealSun96 commented on pull request #1627:
URL: https://github.com/apache/helix/pull/1627#issuecomment-772135228
This PR is ready to be merged, approved by @narendly
Final commit message:
## Fix ZkAddress null case for TaskStateModelFactory ##
If zkAddress is null for the HelixManager passed to TaskStateModelFactory and multizk is not enabled, a NullPointerException will be raised. This PR fixes that by adding a null check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly merged pull request #1627: Fix ZkAddress null case for TaskStateModelFactory
Posted by GitBox <gi...@apache.org>.
narendly merged pull request #1627:
URL: https://github.com/apache/helix/pull/1627
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on a change in pull request #1627: Fix ZkAddress null case for TaskStateModelFactory
Posted by GitBox <gi...@apache.org>.
narendly commented on a change in pull request #1627:
URL: https://github.com/apache/helix/pull/1627#discussion_r569007256
##########
File path: helix-core/src/test/java/org/apache/helix/task/TestTaskStateModelFactory.java
##########
@@ -86,6 +90,15 @@ public void testConfigAccessorCreationMultiZk() throws Exception {
.getTargetThreadPoolSize(zkClient, anyParticipantManager.getClusterName(),
anyParticipantManager.getInstanceName()), TEST_TARGET_TASK_THREAD_POOL_SIZE);
+ // Turn off multiZk mode in System config, and remove zkAddress
+ System.setProperty(SystemPropertyKeys.MULTI_ZK_ENABLED, "false");
+ HelixManager participantManager = Mockito.spy(anyParticipantManager);
+ when(participantManager.getMetadataStoreConnectionString()).thenReturn(null);
+ zkClient = TaskStateModelFactory.createZkClient(participantManager);
+ Assert.assertEquals(TaskUtil
Review comment:
Another good check to add here is `zkClient isinstanceof FederatedZkClient`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on a change in pull request #1627: Fix ZkAddress null case for TaskStateModelFactory
Posted by GitBox <gi...@apache.org>.
narendly commented on a change in pull request #1627:
URL: https://github.com/apache/helix/pull/1627#discussion_r569007256
##########
File path: helix-core/src/test/java/org/apache/helix/task/TestTaskStateModelFactory.java
##########
@@ -86,6 +90,15 @@ public void testConfigAccessorCreationMultiZk() throws Exception {
.getTargetThreadPoolSize(zkClient, anyParticipantManager.getClusterName(),
anyParticipantManager.getInstanceName()), TEST_TARGET_TASK_THREAD_POOL_SIZE);
+ // Turn off multiZk mode in System config, and remove zkAddress
+ System.setProperty(SystemPropertyKeys.MULTI_ZK_ENABLED, "false");
+ HelixManager participantManager = Mockito.spy(anyParticipantManager);
+ when(participantManager.getMetadataStoreConnectionString()).thenReturn(null);
+ zkClient = TaskStateModelFactory.createZkClient(participantManager);
+ Assert.assertEquals(TaskUtil
Review comment:
Another good check to add here is `zkClient isinstanceof FederatedZkClient`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org