You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/01/09 07:45:03 UTC
Review Request 55333: Implemented the 'get()' method of OCI store.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55333/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681
Repository: mesos
Description
-------
Implemented the 'get()' method of OCI store.
Diffs
-----
src/slave/containerizer/mesos/provisioner/oci/paths.hpp PRE-CREATION
src/slave/containerizer/mesos/provisioner/oci/paths.cpp PRE-CREATION
src/slave/containerizer/mesos/provisioner/oci/store.cpp PRE-CREATION
src/slave/containerizer/mesos/provisioner/store.hpp a312ad953b406aa75506051593dcc1c27cdc93af
Diff: https://reviews.apache.org/r/55333/diff/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 55333: Implemented the 'get()' method of OCI store.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55333/#review160875
-----------------------------------------------------------
Patch looks great!
Reviews applied: [52349, 55139, 55140, 52379, 54638, 52382, 54639, 55331, 55332, 55333]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 9, 2017, 7:45 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55333/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2017, 7:45 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the 'get()' method of OCI store.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/oci/paths.hpp PRE-CREATION
> src/slave/containerizer/mesos/provisioner/oci/paths.cpp PRE-CREATION
> src/slave/containerizer/mesos/provisioner/oci/store.cpp PRE-CREATION
> src/slave/containerizer/mesos/provisioner/store.hpp a312ad953b406aa75506051593dcc1c27cdc93af
>
> Diff: https://reviews.apache.org/r/55333/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 55333: Implemented the 'get()' and '__get()'
methods of OCI store.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55333/
-----------------------------------------------------------
(Updated June 1, 2017, 4:42 p.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Changes
-------
Rebased
Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681
Repository: mesos
Description
-------
Implemented the 'get()' and '__get()' methods of OCI store.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/oci/paths.hpp PRE-CREATION
src/slave/containerizer/mesos/provisioner/oci/paths.cpp PRE-CREATION
src/slave/containerizer/mesos/provisioner/oci/store.cpp PRE-CREATION
src/slave/containerizer/mesos/provisioner/store.hpp 01ab83dca79e51b8c96d18ee65705912b0ac8324
Diff: https://reviews.apache.org/r/55333/diff/5/
Changes: https://reviews.apache.org/r/55333/diff/4-5/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 55333: Implemented the 'get()' and '__get()'
methods of OCI store.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55333/
-----------------------------------------------------------
(Updated May 23, 2017, 9:40 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Changes
-------
Minor changes.
Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681
Repository: mesos
Description
-------
Implemented the 'get()' and '__get()' methods of OCI store.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/oci/paths.hpp PRE-CREATION
src/slave/containerizer/mesos/provisioner/oci/paths.cpp PRE-CREATION
src/slave/containerizer/mesos/provisioner/oci/store.cpp PRE-CREATION
src/slave/containerizer/mesos/provisioner/store.hpp 82a9be64264ae829773c1e2e8a4360f78641cbf6
Diff: https://reviews.apache.org/r/55333/diff/4/
Changes: https://reviews.apache.org/r/55333/diff/3-4/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 55333: Implemented the 'get()' and '__get()'
methods of OCI store.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55333/
-----------------------------------------------------------
(Updated March 30, 2017, 10:02 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681
Repository: mesos
Description
-------
Implemented the 'get()' and '__get()' methods of OCI store.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/oci/paths.hpp PRE-CREATION
src/slave/containerizer/mesos/provisioner/oci/paths.cpp PRE-CREATION
src/slave/containerizer/mesos/provisioner/oci/store.cpp PRE-CREATION
src/slave/containerizer/mesos/provisioner/store.hpp 82a9be64264ae829773c1e2e8a4360f78641cbf6
Diff: https://reviews.apache.org/r/55333/diff/3/
Changes: https://reviews.apache.org/r/55333/diff/2-3/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 55333: Implemented the 'get()' and '__get()'
methods of OCI store.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55333/
-----------------------------------------------------------
(Updated Feb. 1, 2017, 9:24 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Changes
-------
Updated by introducing metadata manager.
Summary (updated)
-----------------
Implemented the 'get()' and '__get()' methods of OCI store.
Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681
Repository: mesos
Description (updated)
-------
Implemented the 'get()' and '__get()' methods of OCI store.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/oci/paths.hpp PRE-CREATION
src/slave/containerizer/mesos/provisioner/oci/paths.cpp PRE-CREATION
src/slave/containerizer/mesos/provisioner/oci/store.cpp PRE-CREATION
src/slave/containerizer/mesos/provisioner/store.hpp 82a9be64264ae829773c1e2e8a4360f78641cbf6
Diff: https://reviews.apache.org/r/55333/diff/
Testing
-------
Thanks,
Qian Zhang