[GitHub] zeppelin pull request #2638: fix bugs for paragraph isTerminated method

[wary <gi...@git.apache.org>]

GitHub user wary opened a pull request:

    https://github.com/apache/zeppelin/pull/2638

    fix bugs for paragraph isTerminated method

    …ready
    
    ### What is this PR for?
    The method isTerminate return false forever if a paragraph disabled with status ready, if we schedule a note which have a disabled paragraph with status ready, cron job will be blocked with the code block：
    
    `while (!note.isTerminated()) {
            try {
              Thread.sleep(1000);
            } catch (InterruptedException e) {
              logger.error(e.toString(), e);
            }
          }`
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    [ZEPPELIN-3021]
    
    ### How should this be tested?
    * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
    * Strongly recommended: add automated unit tests for any new or changed behavior
    * Outline any manual steps to test the PR here.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wary/zeppelin FixisTerminated

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2638.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2638
    
----
commit 41411c7a6d56ca3db6cdaf5588f103c2f834718a
Author: lei wang <le...@outlook.com>
Date:   2017-10-31T14:54:10Z

    overwrite method isTerminated for the disabled paragraph with status ready

----


---

[GitHub] zeppelin pull request #2638: [ZEPPELIN-3021]fix bugs for paragraph isTermina...

[wary <gi...@git.apache.org>]

Github user wary closed the pull request at:

    https://github.com/apache/zeppelin/pull/2638


---