You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2017/10/02 09:36:51 UTC
Re: Review Request 62594: Updated scheduler library for modularized
HTTP authenticatee use.
> On Sept. 27, 2017, 10:07 p.m., Greg Mann wrote:
> > src/scheduler/flags.hpp
> > Lines 57-59 (patched)
> > <https://reviews.apache.org/r/62594/diff/1/?file=1836050#file1836050line58>
> >
> > s/kept in in sync/kept in sync/
> >
> > Also, this seems bad :) (also for modules_dir) I wonder if we have a ticket for eliminating this code duplication thru common inheritance?
Yes, lets fix this particular stuff via a ticket and flags inheritance.
> On Sept. 27, 2017, 10:07 p.m., Greg Mann wrote:
> > src/scheduler/scheduler.cpp
> > Line 527 (original), 594 (patched)
> > <https://reviews.apache.org/r/62594/diff/1/?file=1836051#file1836051line623>
> >
> > Hmmm... is this CHECK correct? Since this continuation is registered as an `onAny` callback, couldn't the future be in DISCARDED state? You do handle the discarded case in your new continuation.
We do need to validate how this invariant is guaranteed.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62594/#review186483
-----------------------------------------------------------
On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62594/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 10:54 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, Greg Mann, Kapil Arya, and Vinod Kone.
>
>
> Bugs: MESOS-8021
> https://issues.apache.org/jira/browse/MESOS-8021
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/scheduler/flags.hpp 1e8efc06b40b17d6fa9d9516a83893485804fc72
> src/scheduler/scheduler.cpp 78f53707364ab988bcc53ec2c95490df04cd9a6c
>
>
> Diff: https://reviews.apache.org/r/62594/diff/1/
>
>
> Testing
> -------
>
> Integration test in external project. Further tests upcoming.
>
>
> Thanks,
>
> Till Toenshoff
>
>