You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/09/22 03:43:28 UTC

[GitHub] [rocketmq] RapperCL commented on a diff in pull request #5154: [ISSUE #5151]Reduce redundant for loops

RapperCL commented on code in PR #5154:
URL: https://github.com/apache/rocketmq/pull/5154#discussion_r977164021


##########
client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceImpl.java:
##########
@@ -208,21 +208,16 @@ public void lockAll() {
                     Set<MessageQueue> lockOKMQSet =
                         this.mQClientFactory.getMQClientAPIImpl().lockBatchMQ(findBrokerResult.getBrokerAddr(), requestBody, 1000);
 
-                    for (MessageQueue mq : lockOKMQSet) {
+                    for(MessageQueue mq : mqs){

Review Comment:
   ok thanks, now the code is formatted，you can review it again 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org