You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Pavel Moravec <pm...@redhat.com> on 2014/01/16 13:09:33 UTC
Review Request 16962: QPID-5485: Deleting paged queue does not remove
underlying file
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16962/
-----------------------------------------------------------
Review request for qpid, Ernie Allen and Gordon Sim.
Bugs: https://issues.apache.org/jira/browse/QPID-5485
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/QPID-5485
Repository: qpid
Description
-------
When deleting a paged queue, the broker does not delete the underlying file it created in /var/lib/qpidd directory.
The patch is quite trivial but worth to review from threading point of view as I have no experience in the area.
Diffs
-----
/trunk/qpid/cpp/src/qpid/broker/PagedQueue.h 1558751
/trunk/qpid/cpp/src/qpid/broker/PagedQueue.cpp 1558751
/trunk/qpid/cpp/src/qpid/sys/MemoryMappedFile.h 1558751
/trunk/qpid/cpp/src/qpid/sys/posix/MemoryMappedFile.cpp 1558751
/trunk/qpid/cpp/src/qpid/sys/windows/MemoryMappedFile.cpp 1558751
Diff: https://reviews.apache.org/r/16962/diff/
Testing
-------
file successfully removed when following scenario in QPID-5485
Thanks,
Pavel Moravec
Re: Review Request 16962: QPID-5485: Deleting paged queue does not remove
underlying file
Posted by Pavel Moravec <pm...@redhat.com>.
> On Jan. 16, 2014, 12:27 p.m., Gordon Sim wrote:
> > Looks fine to me. One point to mention I guess is that if the broker crashes the files won't be deleted. A big improvement on no deletion at all however :-)
Thanks for review. committed as r1558790.
- Pavel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16962/#review32018
-----------------------------------------------------------
On Jan. 16, 2014, 12:09 p.m., Pavel Moravec wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16962/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2014, 12:09 p.m.)
>
>
> Review request for qpid, Ernie Allen and Gordon Sim.
>
>
> Bugs: https://issues.apache.org/jira/browse/QPID-5485
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/QPID-5485
>
>
> Repository: qpid
>
>
> Description
> -------
>
> When deleting a paged queue, the broker does not delete the underlying file it created in /var/lib/qpidd directory.
>
> The patch is quite trivial but worth to review from threading point of view as I have no experience in the area.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/broker/PagedQueue.h 1558751
> /trunk/qpid/cpp/src/qpid/broker/PagedQueue.cpp 1558751
> /trunk/qpid/cpp/src/qpid/sys/MemoryMappedFile.h 1558751
> /trunk/qpid/cpp/src/qpid/sys/posix/MemoryMappedFile.cpp 1558751
> /trunk/qpid/cpp/src/qpid/sys/windows/MemoryMappedFile.cpp 1558751
>
> Diff: https://reviews.apache.org/r/16962/diff/
>
>
> Testing
> -------
>
> file successfully removed when following scenario in QPID-5485
>
>
> Thanks,
>
> Pavel Moravec
>
>
Re: Review Request 16962: QPID-5485: Deleting paged queue does not remove
underlying file
Posted by Gordon Sim <gs...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16962/#review32018
-----------------------------------------------------------
Ship it!
Looks fine to me. One point to mention I guess is that if the broker crashes the files won't be deleted. A big improvement on no deletion at all however :-)
- Gordon Sim
On Jan. 16, 2014, 12:09 p.m., Pavel Moravec wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16962/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2014, 12:09 p.m.)
>
>
> Review request for qpid, Ernie Allen and Gordon Sim.
>
>
> Bugs: https://issues.apache.org/jira/browse/QPID-5485
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/QPID-5485
>
>
> Repository: qpid
>
>
> Description
> -------
>
> When deleting a paged queue, the broker does not delete the underlying file it created in /var/lib/qpidd directory.
>
> The patch is quite trivial but worth to review from threading point of view as I have no experience in the area.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/broker/PagedQueue.h 1558751
> /trunk/qpid/cpp/src/qpid/broker/PagedQueue.cpp 1558751
> /trunk/qpid/cpp/src/qpid/sys/MemoryMappedFile.h 1558751
> /trunk/qpid/cpp/src/qpid/sys/posix/MemoryMappedFile.cpp 1558751
> /trunk/qpid/cpp/src/qpid/sys/windows/MemoryMappedFile.cpp 1558751
>
> Diff: https://reviews.apache.org/r/16962/diff/
>
>
> Testing
> -------
>
> file successfully removed when following scenario in QPID-5485
>
>
> Thanks,
>
> Pavel Moravec
>
>