You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/17 00:13:41 UTC

[GitHub] [hudi] kywe665 opened a new pull request #4011: [WIP] - [HUDI-2725] - Add Docs for Pre-Commit Validators

kywe665 opened a new pull request #4011:
URL: https://github.com/apache/hudi/pull/4011


   ## What is the purpose of the pull request
   
   There were no docs for pre-commit validators. This PR will add docs.
   
   ## Brief change log
   
     - Added net new docs for pre-commit validators
   
   ## Verify this pull request
   
   This pull request is docs only.
   
   ## Committer checklist
   
    - [x ] Has a corresponding JIRA in PR title & commit
    
    - [ x] Commit message is descriptive of the change
    
    - [x ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] kywe665 commented on pull request #4011: [WIP] - [HUDI-2725] - Add Docs for Pre-Commit Validators

Posted by GitBox <gi...@apache.org>.
kywe665 commented on pull request #4011:
URL: https://github.com/apache/hudi/pull/4011#issuecomment-970906905


   *WIP* - I have the docs layout and all content done except for the code samples. I was having trouble getting the validators to work so I could test and produce accurate code samples. For example basic tests with SqlQuerySingleResultPreCommitValidator like `SELECT 1 # 0`, (Select 1, expect 0) would still pass. I think I was obviously doing something wrong or misunderstood the code.
   
   *ASK* - I need a review to help get the code samples accurate and usable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 merged pull request #4011: [HUDI-2725] - Add Docs for Pre-Commit Validators

Posted by GitBox <gi...@apache.org>.
danny0405 merged pull request #4011:
URL: https://github.com/apache/hudi/pull/4011


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] kywe665 commented on pull request #4011: [WIP] - [HUDI-2725] - Add Docs for Pre-Commit Validators

Posted by GitBox <gi...@apache.org>.
kywe665 commented on pull request #4011:
URL: https://github.com/apache/hudi/pull/4011#issuecomment-978118164


   finishing code samples


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org