[jira] [Work logged] (KNOX-1858) For a configured list of services fix X-Forwarded-Context header to add service name

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KNOX-1858?focusedWorklogId=244275&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-244275 ]

ASF GitHub Bot logged work on KNOX-1858:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/May/19 20:40
            Start Date: 17/May/19 20:40
    Worklog Time Spent: 10m 
      Work Description: moresandeep commented on pull request #90: KNOX-1858 - Add service name to X-Forwarded-Context header
URL: https://github.com/apache/knox/pull/90
 
 
   
   ## What changes were proposed in this pull request?
   Add a configurable way to append service name to the X-Forward-Context header
   
   ## How was this patch tested?
   Manually  tested using netcat to check headers.
   
   Please review [Knox Contributing Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow) before opening a pull request.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 244275)
            Time Spent: 10m
    Remaining Estimate: 0h

> For a configured list of services fix X-Forwarded-Context header to add service name 
> -------------------------------------------------------------------------------------
>
>                 Key: KNOX-1858
>                 URL: https://issues.apache.org/jira/browse/KNOX-1858
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Server
>            Reporter: Sandeep More
>            Assignee: Sandeep More
>            Priority: Major
>             Fix For: 1.3.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
>  *X-Forward-Context* header for Knox does not behave as it should, it should be */\{gateway}/\{topology}/\{serviceName}* but currently it is */\{gateway}/\{topology}.*
> This will create issues where the proxied applications have no way of knowing the true context (they should not care and mostly they do not, but there are exceptions).
> The problem in fixing this the right way is that we might end up breaking existing applications they rely on this behavior.
> It has been suggested we introduce a config property (gateway.header.x-forward-context.append.servicename) in gateway-site.xml that  will take a list of service names and if the property is defined and list not empty for those services Knox will correct the *X-Forward-Context* header. 
> Proposed config snippet in gateway-site.xml
> {code:java}
>     <property>
>         <name>gateway.header.x-forward-context.append.servicename</name>
>         <value>livy, sparkhistory</value>
>     </property>
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)