[GitHub] [incubator-uniffle] zuston commented on pull request #471: [ISSUE-378][HugePartition][Part-2] Introduce memory usage limit and data flush

[GitBox <gi...@apache.org>]

zuston commented on PR #471:
URL: https://github.com/apache/incubator-uniffle/pull/471#issuecomment-1379751130

   > I don't think we should introduce a new configuration to control buffer flush. rss.server.single.buffer.flush.enabled can be used for the huge partition buffer flush purpose. If the huge partition limit is enabled, the single buffer flush could be enabled automatically.
   
   If single buffer flush could be enabled automatically, how to set the flush threshold size? I don't hope the `rss.server.single.buffer.flush.enabled` is enabled for regular partitions, which could be flushed to ssd/hdd directly instead of cold storage. And huge partition could be flushed to HDFS.
   
   > I think these two similar configurations will bring more confusion to end user.
   
   Emm. Yes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org