You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2016/05/11 15:45:04 UTC

Review Request 47241: GEODE-1203: include spring-web in gfshDependency.jar

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47241/
-----------------------------------------------------------

Review request for geode, Jens Deppe, Kirk Lund, and Dan Smith.


Repository: geode


Description
-------

GEODE-1203: include spring-web in gfshDependency.jar


Diffs
-----

  geode-assembly/build.gradle ed5154edef65a484525cdec21a1ad3fa37fe7864 

Diff: https://reviews.apache.org/r/47241/diff/


Testing
-------

installDist and gfsh connect use http


Thanks,

Jinmei Liao


Re: Review Request 47241: GEODE-1203: include spring-web in gfshDependency.jar

Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47241/#review132682
-----------------------------------------------------------


Ship it!




Ship It!

- Dan Smith


On May 11, 2016, 3:45 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47241/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 3:45 p.m.)
> 
> 
> Review request for geode, Jens Deppe, Kirk Lund, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1203: include spring-web in gfshDependency.jar
> 
> 
> Diffs
> -----
> 
>   geode-assembly/build.gradle ed5154edef65a484525cdec21a1ad3fa37fe7864 
> 
> Diff: https://reviews.apache.org/r/47241/diff/
> 
> 
> Testing
> -------
> 
> installDist and gfsh connect use http
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>


Re: Review Request 47241: GEODE-1203: include spring-web in gfshDependency.jar

Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47241/#review133149
-----------------------------------------------------------


Ship it!




Ship It!

- Kirk Lund


On May 11, 2016, 3:45 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47241/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 3:45 p.m.)
> 
> 
> Review request for geode, Jens Deppe, Kirk Lund, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1203: include spring-web in gfshDependency.jar
> 
> 
> Diffs
> -----
> 
>   geode-assembly/build.gradle ed5154edef65a484525cdec21a1ad3fa37fe7864 
> 
> Diff: https://reviews.apache.org/r/47241/diff/
> 
> 
> Testing
> -------
> 
> installDist and gfsh connect use http
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>


Re: Review Request 47241: GEODE-1203: include spring-web in gfshDependency.jar

Posted by Mark Bretl <mb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47241/#review132685
-----------------------------------------------------------


Ship it!




Ship It!

- Mark Bretl


On May 11, 2016, 8:45 a.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47241/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 8:45 a.m.)
> 
> 
> Review request for geode, Jens Deppe, Kirk Lund, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1203: include spring-web in gfshDependency.jar
> 
> 
> Diffs
> -----
> 
>   geode-assembly/build.gradle ed5154edef65a484525cdec21a1ad3fa37fe7864 
> 
> Diff: https://reviews.apache.org/r/47241/diff/
> 
> 
> Testing
> -------
> 
> installDist and gfsh connect use http
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>