You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/04 15:31:14 UTC

[GitHub] [airflow] Taragolis commented on a diff in pull request #23560: Add advanced secrets backend configurations

Taragolis commented on code in PR #23560:
URL: https://github.com/apache/airflow/pull/23560#discussion_r913105349


##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -422,6 +422,13 @@ backend =
 # ``{{"connections_prefix": "/airflow/connections", "profile_name": "default"}}``
 backend_kwargs =
 
+# Advanced secrets backend configuration, allow to user configure more than one secret backend,
+# order of secrets backend and turn off built-in backends.
+# Expected JSON list of objects. See
+# https://airflow.apache.org/docs/apache-airflow/stable/security/secrets/secrets-backend/index.html#advanced-configuration
+# for more details.
+backends_config =

Review Comment:
   Oh... default value for current implementation - "not defined", null or None and fallback to current implementation.
   
   However if we decide to keep only one way to configure backends in this case we might set as default:
   ```ini
   backends_config = [{"backend":"airflow.secrets.environment_variables.EnvironmentVariablesBackend"}, {"backend":"airflow.secrets.metastore.MetastoreBackend"}]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org