You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/05 22:37:41 UTC
[GitHub] [airflow] potiuk opened a new pull request #18040: Fix providers tests in main branch with eager upgrades
potiuk opened a new pull request #18040:
URL: https://github.com/apache/airflow/pull/18040
The SQS and DataCatalog were failing tests in main branch because
some recent release of dependencies broke them:
1) SQS moto 2.2.6 broke SQS tests - limitation was added to
moto library for now
2) DataCatalog part of Google Provider incorrectly imported
types and broke tests (used beta instad of datacatalog path
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #18040: Fix providers tests in main branch with eager upgrades
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #18040:
URL: https://github.com/apache/airflow/pull/18040#issuecomment-913391168
Hmm, Sphinx does not seem to like this?
```
TypeError("unsupported operand type(s) for +: 'SSL_VERIFY_PEER' and 'SSL_VERIFY_FAIL_IF_NO_PEER_CERT'")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18040: Fix providers tests in main branch with eager upgrades
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18040:
URL: https://github.com/apache/airflow/pull/18040#issuecomment-913450751
Thanks @uranusjr for help! the SQS tests should now be working even with moto >= 2.2.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #18040: Fix providers tests in main branch with eager upgrades
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #18040:
URL: https://github.com/apache/airflow/pull/18040#issuecomment-913404073
> @potiuk Could you add some context how 2.2.6 and 2.2.7 break the tests? This information would be useful in the future when we consider relaxing the version range.
Srsly I do not know yet :). When we upgrade to 2.2.6, the sqs tests fail with https://github.com/apache/airflow/runs/3518155510?check_suite_focus=true#step:6:9582
```
tests/providers/amazon/aws/operators/test_sqs.py::TestSQSPublishOperator::test_execute_success: botocore.exceptions.ClientError: An error occurred (InvalidAddress) when calling the SendMessage operation: The address test is not valid for this endpoint.
tests/providers/amazon/aws/sensors/test_sqs.py::TestSQSSensor::test_poke_message_invalid_filtering: botocore.exceptions.ClientError: An error occurred (InvalidAddress) when calling the SendMessage operation: The address test is not valid for this endpoint.
tests/providers/amazon/aws/sensors/test_sqs.py::TestSQSSensor::test_poke_no_message_failed: botocore.exceptions.ClientError: An error occurred (InvalidAddress) when calling the ReceiveMessage operation: The address test is not valid for this endpoint.
tests/providers/amazon/aws/sensors/test_sqs.py::TestSQSSensor::test_poke_success: botocore.exceptions.ClientError: An error occurred (InvalidAddress) when calling the SendMessage operation: The address test is not valid for this endpoint.
```
Any help/suggestions/guesses are welcome. I would love to fix those tests rather than limit `moto` but if we can't find the reason quickly, limiting moto might be a faster way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18040: Fix providers tests in main branch with eager upgrades
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18040:
URL: https://github.com/apache/airflow/pull/18040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18040: Fix providers tests in main branch with eager upgrades
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18040:
URL: https://github.com/apache/airflow/pull/18040#issuecomment-913451004
I will deal with doc builds separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18040: Fix providers tests in main branch with eager upgrades
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18040:
URL: https://github.com/apache/airflow/pull/18040#issuecomment-913402043
> ```
> TypeError("unsupported operand type(s) for +: 'SSL_VERIFY_PEER' and 'SSL_VERIFY_FAIL_IF_NO_PEER_CERT'")
> ```
Yeah, I was loooking in the evening yesterday and tried to pin-point where this one is coming from. If you have any idea, how to approach that one it would be great. I could not find any clue or similar issues.
It looks like some dependency (but I have no idea which one) causes this one. For now I was trying to downgrade each of the dependencies one-by-one to the version that "works" (current constraint) but this is a bit "hit-and-miss" approach and that will take me a while to go through it. Any wild guesses ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18040: Fix providers tests in main branch with eager upgrades
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18040:
URL: https://github.com/apache/airflow/pull/18040#issuecomment-913404073
> @potiuk Could you add some context how 2.2.6 and 2.2.7 break the tests? This information would be useful in the future when we consider relaxing the version range.
Srsly I do not know yet :). When we upgrade to 2.2.6, the sqs tests fail with https://github.com/apache/airflow/runs/3518155510?check_suite_focus=true#step:6:9582
```
tests/providers/amazon/aws/operators/test_sqs.py::TestSQSPublishOperator::test_execute_success: botocore.exceptions.ClientError: An error occurred (InvalidAddress) when calling the SendMessage operation: The address test is not valid for this endpoint.
tests/providers/amazon/aws/sensors/test_sqs.py::TestSQSSensor::test_poke_message_invalid_filtering: botocore.exceptions.ClientError: An error occurred (InvalidAddress) when calling the SendMessage operation: The address test is not valid for this endpoint.
tests/providers/amazon/aws/sensors/test_sqs.py::TestSQSSensor::test_poke_no_message_failed: botocore.exceptions.ClientError: An error occurred (InvalidAddress) when calling the ReceiveMessage operation: The address test is not valid for this endpoint.
tests/providers/amazon/aws/sensors/test_sqs.py::TestSQSSensor::test_poke_success: botocore.exceptions.ClientError: An error occurred (InvalidAddress) when calling the SendMessage operation: The address test is not valid for this endpoint.
tests/providers/google/cloud/hooks/test_datacatalog.py::TestCloudDataCatalogWithDefaultProjectIdHook::test_create_tag_template: AssertionError: Expected call: create_tag_template(metadata=(), request=parent: "projects/example-project-1/locations/europe-west-3b"
```
Any help/suggestions/guesses are welcome. I would love to fix those tests rather than limit `moto` but if we can't find the reason quickly, limiting moto might be a faster way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18040: Fix providers tests in main branch with eager upgrades
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18040:
URL: https://github.com/apache/airflow/pull/18040#issuecomment-913239378
Another set of fixes to failing "eager-upgrade" tests in `main`. Hopefully the last one (still a docs build error remains despite recent fix)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18040: Fix providers tests in main branch with eager upgrades
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18040:
URL: https://github.com/apache/airflow/pull/18040#issuecomment-913240919
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #18040: Fix providers tests in main branch with eager upgrades
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #18040:
URL: https://github.com/apache/airflow/pull/18040#issuecomment-913390103
@potiuk Could you add some context how 2.2.6 and 2.2.7 break the tests? This information would be useful in the future when we consider relaxing the version range.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18040: Fix providers tests in main branch with eager upgrades
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18040:
URL: https://github.com/apache/airflow/pull/18040#issuecomment-913477853
The static checks fail due to .docker.json corruption (another race condition). Merging to test it in `main`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org