[jira] [Comment Edited] (HBASE-15643) Need metrics of cache hit ratio, etc for one table

["Anoop Sam John (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372168#comment-15372168 ] 

Anoop Sam John edited comment on HBASE-15643 at 7/12/16 4:43 AM:
-----------------------------------------------------------------

LruBlockCache 
{code}
 stats.incrementBlockCountForTable(cacheKey.getTableName());
366	    stats.incrementBlockSizeForTable(cacheKey.getTableName(), cb.heapSize());
{code}
L1/L2 cache look up and read is in hot path and there adding code like above which involve a Map lookup operation will be perf hit. That is what the comment means.  Agree with it.  We should be careful abt doing this.


was (Author: anoop.hbase):
LruBlockCache 
{code}
 stats.incrementBlockCountForTable(cacheKey.getTableName());
366	    stats.incrementBlockSizeForTable(cacheKey.getTableName(), cb.heapSize());
{code}
L1/L2 cache look up and read is in hot path and there adding code like above which involve a Map lookup operation will be perf hit. That is what the comment means.

> Need metrics of cache hit ratio, etc for one table
> --------------------------------------------------
>
>                 Key: HBASE-15643
>                 URL: https://issues.apache.org/jira/browse/HBASE-15643
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Heng Chen
>            Assignee: Alicia Ying Shu
>         Attachments: HBASE-15643.patch
>
>
> There are many tables on our cluster,  only some of them need to be read online.  
> We could improve the performance of read by cache,  but we need some metrics for it at table level. There are a few we can collect: BlockCacheCount, BlockCacheSize, BlockCacheHitCount, BlockCacheMissCount, BlockCacheHitPercent



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)