You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "mapleFU (via GitHub)" <gi...@apache.org> on 2023/08/11 16:32:11 UTC

[GitHub] [arrow] mapleFU opened a new issue, #37126: [C++][Parquet] Parquet PlainBooleanDecoder doesn't handle `num_values_` in a right way

mapleFU opened a new issue, #37126:
URL: https://github.com/apache/arrow/issues/37126

   ### Describe the bug, including details regarding any error messages, version, and platform.
   
   
   ```c++
   int PlainBooleanDecoder::Decode(bool* buffer, int max_values) {
     max_values = std::min(max_values, num_values_);
     if (bit_reader_->GetBatch(1, buffer, max_values) != max_values) {
       ParquetException::EofException();
     }
     num_values_ -= max_values;
     return max_values;
   }
   ```
   
   Seems that this function didn't handle `num_values_` in a right way. `num_values_` is maximum of existing value (including null), it might be greater than existing value count.
   
   ### Component(s)
   
   C++, Parquet


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] mapleFU commented on issue #37126: [C++][Parquet] Parquet PlainBooleanDecoder doesn't handle `num_values_` in a right way

Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on issue #37126:
URL: https://github.com/apache/arrow/issues/37126#issuecomment-1675068532

   However, this would not be a severe problem, because most of time, outside will handle `max_size` well. We just need to unify the handling of `num_values_`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [C++][Parquet] Parquet PlainBooleanDecoder doesn't handle `num_values_` in a right way [arrow]

Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU closed issue #37126: [C++][Parquet] Parquet PlainBooleanDecoder doesn't handle `num_values_` in a right way
URL: https://github.com/apache/arrow/issues/37126


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org