You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/01/29 17:33:33 UTC

[GitHub] [sling-org-apache-sling-distribution-core] joerghoh commented on a change in pull request #44: SLING-8595 update to bundle-parent 40

joerghoh commented on a change in pull request #44:
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/44#discussion_r566981922



##########
File path: src/test/java/org/apache/sling/distribution/queue/impl/simple/QueueItemMapperTest.java
##########
@@ -22,13 +22,15 @@
 import java.util.Map;
 
 import org.apache.sling.distribution.queue.DistributionQueueItem;
+import org.junit.Ignore;
 import org.junit.Test;
 
 import static org.junit.Assert.*;
 
 public class QueueItemMapperTest {
 
     @Test
+    @Ignore

Review comment:
       The problem here is a [local dependent parsing of numbers in QueueMapperImpl](https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/queue/impl/simple/QueueItemMapper.java#L55). We can defintely hardocde it to English locale (and have the "." as decimal separator) to fix it. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org