You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by rd...@apache.org on 2009/09/16 10:33:30 UTC
svn commit: r815666 - in /james/server/trunk:
nntpserver-function/src/main/java/org/apache/james/nntpserver/
pop3server-function/src/main/java/org/apache/james/pop3server/
remotemanager-function/src/main/java/org/apache/james/remotemanager/
Author: rdonkin
Date: Wed Sep 16 08:33:30 2009
New Revision: 815666
URL: http://svn.apache.org/viewvc?rev=815666&view=rev
Log:
Replace StringBuffer with StringBuilder
Modified:
james/server/trunk/nntpserver-function/src/main/java/org/apache/james/nntpserver/NNTPHandler.java
james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3Handler.java
james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3Session.java
james/server/trunk/remotemanager-function/src/main/java/org/apache/james/remotemanager/RemoteManagerHandler.java
Modified: james/server/trunk/nntpserver-function/src/main/java/org/apache/james/nntpserver/NNTPHandler.java
URL: http://svn.apache.org/viewvc/james/server/trunk/nntpserver-function/src/main/java/org/apache/james/nntpserver/NNTPHandler.java?rev=815666&r1=815665&r2=815666&view=diff
==============================================================================
--- james/server/trunk/nntpserver-function/src/main/java/org/apache/james/nntpserver/NNTPHandler.java (original)
+++ james/server/trunk/nntpserver-function/src/main/java/org/apache/james/nntpserver/NNTPHandler.java Wed Sep 16 08:33:30 2009
@@ -261,15 +261,15 @@
public void handleProtocol() throws IOException {
// section 7.1
if ( theConfigData.getNNTPRepository().isReadOnly() ) {
- StringBuffer respBuffer =
- new StringBuffer(128)
+ StringBuilder respBuffer =
+ new StringBuilder(128)
.append("201 ")
.append(theConfigData.getHelloName())
.append(" NNTP Service Ready, posting prohibited");
helper.writeLoggedFlushedResponse(respBuffer.toString());
} else {
- StringBuffer respBuffer =
- new StringBuffer(128)
+ StringBuilder respBuffer =
+ new StringBuilder(128)
.append("200 ")
.append(theConfigData.getHelloName())
.append(" NNTP Service Ready, posting permitted");
@@ -419,8 +419,8 @@
*/
private void doUnknownCommand(String command, String argument) {
if (helper.getLogger().isDebugEnabled()) {
- StringBuffer logBuffer =
- new StringBuffer(128)
+ StringBuilder logBuffer =
+ new StringBuilder(128)
.append("Received unknown command ")
.append(command)
.append(" with argument ")
@@ -539,8 +539,8 @@
while ( groupIter.hasNext() ) {
Iterator articleIter = ((NNTPGroup)(groupIter.next())).getArticlesSince(theDate);
while (articleIter.hasNext()) {
- StringBuffer iterBuffer =
- new StringBuffer(64)
+ StringBuilder iterBuffer =
+ new StringBuilder(64)
.append(((NNTPArticle)articleIter.next()).getUniqueID());
helper.writeLoggedResponse(iterBuffer.toString());
}
@@ -577,8 +577,8 @@
helper.writeLoggedFlushedResponse("231 list of new newsgroups follows");
while ( iter.hasNext() ) {
NNTPGroup currentGroup = (NNTPGroup)iter.next();
- StringBuffer iterBuffer =
- new StringBuffer(128)
+ StringBuilder iterBuffer =
+ new StringBuilder(128)
.append(currentGroup.getName())
.append(" ")
.append(currentGroup.getLastArticleNumber())
@@ -753,8 +753,8 @@
helper.writeLoggedFlushedResponse("430 no such article");
return;
} else {
- StringBuffer respBuffer =
- new StringBuffer(64)
+ StringBuilder respBuffer =
+ new StringBuilder(64)
.append("223 0 ")
.append(param);
helper.writeLoggedFlushedResponse(respBuffer.toString());
@@ -786,8 +786,8 @@
if (articleID == null) {
articleID = "<0>";
}
- StringBuffer respBuffer =
- new StringBuffer(128)
+ StringBuilder respBuffer =
+ new StringBuilder(128)
.append("223 ")
.append(article.getArticleNumber())
.append(" ")
@@ -816,8 +816,8 @@
helper.writeLoggedFlushedResponse("430 no such article");
return;
} else {
- StringBuffer respBuffer =
- new StringBuffer(64)
+ StringBuilder respBuffer =
+ new StringBuilder(64)
.append("222 0 ")
.append(param);
helper.writeLoggedFlushedResponse(respBuffer.toString());
@@ -849,8 +849,8 @@
if (articleID == null) {
articleID = "<0>";
}
- StringBuffer respBuffer =
- new StringBuffer(128)
+ StringBuilder respBuffer =
+ new StringBuilder(128)
.append("222 ")
.append(article.getArticleNumber())
.append(" ")
@@ -884,8 +884,8 @@
helper.writeLoggedFlushedResponse("430 no such article");
return;
} else {
- StringBuffer respBuffer =
- new StringBuffer(64)
+ StringBuilder respBuffer =
+ new StringBuilder(64)
.append("221 0 ")
.append(param);
helper.writeLoggedFlushedResponse(respBuffer.toString());
@@ -917,8 +917,8 @@
if (articleID == null) {
articleID = "<0>";
}
- StringBuffer respBuffer =
- new StringBuffer(128)
+ StringBuilder respBuffer =
+ new StringBuilder(128)
.append("221 ")
.append(article.getArticleNumber())
.append(" ")
@@ -952,8 +952,8 @@
helper.writeLoggedFlushedResponse("430 no such article");
return;
} else {
- StringBuffer respBuffer =
- new StringBuffer(64)
+ StringBuilder respBuffer =
+ new StringBuilder(64)
.append("220 0 ")
.append(param);
helper.writeLoggedResponse(respBuffer.toString());
@@ -985,8 +985,8 @@
if (articleID == null) {
articleID = "<0>";
}
- StringBuffer respBuffer =
- new StringBuffer(128)
+ StringBuilder respBuffer =
+ new StringBuilder(128)
.append("220 ")
.append(article.getArticleNumber())
.append(" ")
@@ -1021,8 +1021,8 @@
} else {
currentArticleNumber++;
NNTPArticle article = group.getArticle(currentArticleNumber);
- StringBuffer respBuffer =
- new StringBuffer(64)
+ StringBuilder respBuffer =
+ new StringBuilder(64)
.append("223 ")
.append(article.getArticleNumber())
.append(" ")
@@ -1050,8 +1050,8 @@
} else {
currentArticleNumber--;
NNTPArticle article = group.getArticle(currentArticleNumber);
- StringBuffer respBuffer =
- new StringBuffer(64)
+ StringBuilder respBuffer =
+ new StringBuilder(64)
.append("223 ")
.append(article.getArticleNumber())
.append(" ")
@@ -1093,8 +1093,8 @@
} else {
currentArticleNumber = -1;
}
- StringBuffer respBuffer =
- new StringBuffer(128)
+ StringBuilder respBuffer =
+ new StringBuilder(128)
.append("211 ")
.append(articleCount)
.append(" ")
@@ -1260,8 +1260,8 @@
if ( val == null ) {
val = "";
}
- StringBuffer hdrBuffer =
- new StringBuffer(128)
+ StringBuilder hdrBuffer =
+ new StringBuilder(128)
.append(article[i].getArticleNumber())
.append(" ")
.append(val);
@@ -1386,19 +1386,19 @@
String time = tok.nextToken();
boolean utc = ( tok.hasMoreTokens() );
try {
- StringBuffer dateStringBuffer =
- new StringBuffer(64)
+ StringBuilder dateStringBuilder =
+ new StringBuilder(64)
.append(date)
.append(" ")
.append(time);
- Date dt = DF_RFC977.parse(dateStringBuffer.toString());
+ Date dt = DF_RFC977.parse(dateStringBuilder.toString());
if ( utc ) {
dt = new Date(dt.getTime()+UTC_OFFSET);
}
return dt;
} catch ( ParseException pe ) {
- StringBuffer exceptionBuffer =
- new StringBuffer(128)
+ StringBuilder exceptionBuffer =
+ new StringBuilder(128)
.append("Date extraction failed: ")
.append(date)
.append(",")
Modified: james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3Handler.java
URL: http://svn.apache.org/viewvc/james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3Handler.java?rev=815666&r1=815665&r2=815666&view=diff
==============================================================================
--- james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3Handler.java (original)
+++ james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3Handler.java Wed Sep 16 08:33:30 2009
@@ -111,7 +111,7 @@
/**
* The per-handler response buffer used to marshal responses.
*/
- private StringBuffer responseBuffer = new StringBuffer(256);
+ private StringBuilder responseBuffer = new StringBuilder(256);
/**
@@ -244,8 +244,8 @@
}
helper.getWatchdog().stop();
if (helper.getLogger().isInfoEnabled()) {
- StringBuffer logBuffer =
- new StringBuffer(128)
+ StringBuilder logBuffer =
+ new StringBuilder(128)
.append("Connection for ")
.append(getUser())
.append(" from ")
@@ -382,7 +382,7 @@
/**
* @see org.apache.james.pop3server.POP3Session#getResponseBuffer()
*/
- public StringBuffer getResponseBuffer() {
+ public StringBuilder getResponseBuffer() {
return responseBuffer;
}
Modified: james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3Session.java
URL: http://svn.apache.org/viewvc/james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3Session.java?rev=815666&r1=815665&r2=815666&view=diff
==============================================================================
--- james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3Session.java (original)
+++ james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/POP3Session.java Wed Sep 16 08:33:30 2009
@@ -59,7 +59,7 @@
*
* @return responseBuffer
*/
- StringBuffer getResponseBuffer();
+ StringBuilder getResponseBuffer();
/**
* Clears the response buffer, returning the String of characters in the buffer.
Modified: james/server/trunk/remotemanager-function/src/main/java/org/apache/james/remotemanager/RemoteManagerHandler.java
URL: http://svn.apache.org/viewvc/james/server/trunk/remotemanager-function/src/main/java/org/apache/james/remotemanager/RemoteManagerHandler.java?rev=815666&r1=815665&r2=815666&view=diff
==============================================================================
--- james/server/trunk/remotemanager-function/src/main/java/org/apache/james/remotemanager/RemoteManagerHandler.java (original)
+++ james/server/trunk/remotemanager-function/src/main/java/org/apache/james/remotemanager/RemoteManagerHandler.java Wed Sep 16 08:33:30 2009
@@ -153,16 +153,16 @@
password = helper.getInputReader().readLine().trim();
} while (!password.equals(theConfigData.getAdministrativeAccountData().get(login)) || password.length() == 0);
- StringBuffer messageBuffer =
- new StringBuffer(64)
+ StringBuilder messageBuffer =
+ new StringBuilder(64)
.append("Welcome ")
.append(login)
.append(". HELP for a list of commands");
helper.getOutputWriter().println( messageBuffer.toString() );
helper.getOutputWriter().flush();
if (helper.getLogger().isInfoEnabled()) {
- StringBuffer infoBuffer =
- new StringBuffer(128)
+ StringBuilder infoBuffer =
+ new StringBuilder(128)
.append("Login for ")
.append(login)
.append(" successful");
@@ -185,8 +185,8 @@
System.out.println("Exception: " + thr.getMessage());
helper.getLogger().error("Encountered exception in handling the remote manager connection.", thr);
}
- StringBuffer infoBuffer =
- new StringBuffer(64)
+ StringBuilder infoBuffer =
+ new StringBuilder(64)
.append("Logout for ")
.append(login)
.append(".");
@@ -201,8 +201,8 @@
helper.getOutputWriter().println("Unexpected Error: "+e.getMessage());
helper.getOutputWriter().flush();
if (helper.getLogger().isErrorEnabled()) {
- StringBuffer exceptionBuffer =
- new StringBuffer(128)
+ StringBuilder exceptionBuffer =
+ new StringBuilder(128)
.append("Exception during connection from ")
.append(helper.getRemoteHost())
.append(" (")
@@ -310,8 +310,8 @@
boolean success = false;
if (users.contains(username)) {
- StringBuffer responseBuffer =
- new StringBuffer(64)
+ StringBuilder responseBuffer =
+ new StringBuilder(64)
.append("User ")
.append(username)
.append(" already exists");
@@ -334,8 +334,8 @@
success = users.addUser(username, passwd);
}
if ( success ) {
- StringBuffer responseBuffer =
- new StringBuffer(64)
+ StringBuilder responseBuffer =
+ new StringBuilder(64)
.append("User ")
.append(username)
.append(" added");
@@ -380,8 +380,8 @@
boolean success = user.setPassword(passwd);
if (success) {
users.updateUser(user);
- StringBuffer responseBuffer =
- new StringBuffer(64)
+ StringBuilder responseBuffer =
+ new StringBuilder(64)
.append("Password for ")
.append(username)
.append(" reset");
@@ -411,8 +411,8 @@
if (users.contains(user)) {
try {
users.removeUser(user);
- StringBuffer responseBuffer =
- new StringBuffer(64)
+ StringBuilder responseBuffer =
+ new StringBuilder(64)
.append("User ")
.append(user)
.append(" deleted");
@@ -420,8 +420,8 @@
helper.getOutputWriter().println(response);
helper.getLogger().info(response);
} catch (Exception e) {
- StringBuffer exceptionBuffer =
- new StringBuffer(128)
+ StringBuilder exceptionBuffer =
+ new StringBuilder(128)
.append("Error deleting user ")
.append(user)
.append(" : ")
@@ -431,8 +431,8 @@
helper.getLogger().error(exception);
}
} else {
- StringBuffer responseBuffer =
- new StringBuffer(64)
+ StringBuilder responseBuffer =
+ new StringBuilder(64)
.append("User ")
.append(user)
.append(" doesn't exist");
@@ -509,16 +509,16 @@
return true;
}
if (users.contains(user)) {
- StringBuffer responseBuffer =
- new StringBuffer(64)
+ StringBuilder responseBuffer =
+ new StringBuilder(64)
.append("User ")
.append(user)
.append(" exists");
String response = responseBuffer.toString();
helper.writeLoggedResponse(response);
} else {
- StringBuffer responseBuffer =
- new StringBuffer(64)
+ StringBuilder responseBuffer =
+ new StringBuilder(64)
.append("User ")
.append(user)
.append(" does not exist");
@@ -622,8 +622,8 @@
if (success) {
user.setAliasing(true);
users.updateUser(user);
- StringBuffer responseBuffer =
- new StringBuffer(64)
+ StringBuilder responseBuffer =
+ new StringBuilder(64)
.append("Alias for ")
.append(username)
.append(" set to:")
@@ -683,8 +683,8 @@
if (success) {
user.setForwarding(true);
users.updateUser(user);
- StringBuffer responseBuffer =
- new StringBuffer(64)
+ StringBuilder responseBuffer =
+ new StringBuilder(64)
.append("Forwarding destination for ")
.append(username)
.append(" set to:")
@@ -809,8 +809,8 @@
} else if (user.getAliasing()){
user.setAliasing(false);
users.updateUser(user);
- StringBuffer responseBuffer =
- new StringBuffer(64)
+ StringBuilder responseBuffer =
+ new StringBuilder(64)
.append("Alias for ")
.append(username)
.append(" unset");
@@ -842,8 +842,8 @@
} else if (user.getForwarding()){
user.setForwarding(false);
users.updateUser(user);
- StringBuffer responseBuffer =
- new StringBuffer(64)
+ StringBuilder responseBuffer =
+ new StringBuilder(64)
.append("Forward for ")
.append(username)
.append(" unset");
@@ -874,8 +874,8 @@
helper.writeLoggedFlushedResponse("No such repository: " + repositoryName);
} else {
users = repos;
- StringBuffer responseBuffer =
- new StringBuffer(64)
+ StringBuilder responseBuffer =
+ new StringBuilder(64)
.append("Changed to repository '")
.append(repositoryName)
.append("'.");
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org