You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2015/10/13 23:38:19 UTC
[GitHub] couchdb-fauxton pull request: Sidebar automatically updates after ...
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/555
Sidebar automatically updates after design doc deleted
After deleting a design doc, the sidebar didn't refresh, so you'd
see the old data until the next repaint. This explicitly updates
the sidebar after all document deletes (React will handle the
nasty diffing for us, so it'll be performant).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton sidebar-update-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/555.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #555
----
commit c81a974ff8f0cdf29716cc798610c866ad981f3c
Author: Ben Keen <be...@gmail.com>
Date: 2015-10-13T21:37:43Z
Sidebar automatically updates after design doc deleted
After deleting a design doc, the sidebar didn't refresh, so you'd
see the old data until the next repaint. This explicitly updates
the sidebar after all document deletes (React will handle the
nasty diffing for us, so it'll be performant).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Sidebar automatically updates after ...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/555#issuecomment-151194801
Thanks @sebastianrothbucher. Good call on the action spec tests - added. Will merge when green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Sidebar automatically updates after ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/555
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Sidebar automatically updates after ...
Posted by sebastianrothbucher <gi...@git.apache.org>.
Github user sebastianrothbucher commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/555#issuecomment-149019493
LGTM +1
You could add one more unit tests (or copy it from here: https://github.com/benkeen/couchdb-fauxton/compare/sidebar-update-fix...sebastianrothbucher:sidebar-update-fix_sr?expand=1)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Sidebar automatically updates after ...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/555#issuecomment-150318902
Thanks @sebastianrothbucher! Will look at this soon, I hope...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---