You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "cfmcgrady (via GitHub)" <gi...@apache.org> on 2023/07/10 10:12:37 UTC
[GitHub] [incubator-celeborn] cfmcgrady opened a new pull request, #1699: [CELEBORN-783] Revise the conditions for the `SortBasedPusher#insertRecord` method
cfmcgrady opened a new pull request, #1699:
URL: https://github.com/apache/incubator-celeborn/pull/1699
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
As title
### Why are the changes needed?
[comment](https://github.com/apache/incubator-celeborn/commit/7adf1fca41cd34eb3e9ddf5cc8cd24674ab585b4?notification_referrer_id=NT_kwDOAIJHFbI3MDEyMzc0NzkwOjg1Mzc4Nzc#r121138008)
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
New UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture closed pull request #1699: [CELEBORN-783] Revise the conditions for the `SortBasedPusher#insertRecord` method
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #1699: [CELEBORN-783] Revise the conditions for the `SortBasedPusher#insertRecord` method
URL: https://github.com/apache/incubator-celeborn/pull/1699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1699: [CELEBORN-783] Revise the conditions for the `SortBasedPusher#insertRecord` method
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1699:
URL: https://github.com/apache/incubator-celeborn/pull/1699#issuecomment-1628694985
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1699?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1699](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1699?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f494534) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/334f0e5ba4ad3aadd1869ad0590cbd3a60a77bee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (334f0e5) will **increase** coverage by `0.21%`.
> The diff coverage is `n/a`.
> :exclamation: Current head f494534 differs from pull request most recent head e07d9f5. Consider uploading reports for the commit e07d9f5 to get more accurate results
```diff
@@ Coverage Diff @@
## main #1699 +/- ##
==========================================
+ Coverage 46.43% 46.64% +0.21%
==========================================
Files 161 161
Lines 10018 10018
Branches 928 928
==========================================
+ Hits 4651 4672 +21
+ Misses 5051 5034 -17
+ Partials 316 312 -4
```
[see 2 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1699/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cfmcgrady commented on a diff in pull request #1699: [CELEBORN-783] Revise the conditions for the `SortBasedPusher#insertRecord` method
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on code in PR #1699:
URL: https://github.com/apache/incubator-celeborn/pull/1699#discussion_r1259160804
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/celeborn/SortBasedPusher.java:
##########
@@ -57,7 +57,6 @@ public class SortBasedPusher extends MemoryConsumer {
private final int pushBufferMaxSize;
private final long pushSortMemoryThreshold;
final int uaoSize = UnsafeAlignedOffset.getUaoSize();
Review Comment:
raised a follow-up https://github.com/apache/incubator-celeborn/pull/1704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cfmcgrady commented on pull request #1699: [CELEBORN-783] Revise the conditions for the `SortBasedPusher#insertRecord` method
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #1699:
URL: https://github.com/apache/incubator-celeborn/pull/1699#issuecomment-1628647550
@waitinfuture @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1699: [CELEBORN-783] Revise the conditions for the `SortBasedPusher#insertRecord` method
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1699:
URL: https://github.com/apache/incubator-celeborn/pull/1699#discussion_r1259137323
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/celeborn/SortBasedPusher.java:
##########
@@ -57,7 +57,6 @@ public class SortBasedPusher extends MemoryConsumer {
private final int pushBufferMaxSize;
private final long pushSortMemoryThreshold;
final int uaoSize = UnsafeAlignedOffset.getUaoSize();
Review Comment:
static?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org