You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (JIRA)" <ji...@apache.org> on 2012/07/09 04:34:34 UTC
[jira] [Created] (BOOKKEEPER-329) provide stop scripts for hub
server
Sijie Guo created BOOKKEEPER-329:
------------------------------------
Summary: provide stop scripts for hub server
Key: BOOKKEEPER-329
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-329
Project: Bookkeeper
Issue Type: Bug
Components: hedwig-server
Affects Versions: 4.1.0, 4.0.0
Reporter: Sijie Guo
Assignee: Sijie Guo
Fix For: 4.2.0
as what we did in BOOKKEEPER-296, it would be better to provide similar script to start/stop hub server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-329) provide stop scripts for hub
server
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410462#comment-13410462 ]
Ivan Kelly commented on BOOKKEEPER-329:
---------------------------------------
The script doesn't work as I would expect it to (this also holds for bookkeeper-daemon.sh).
{quote}
$ sh hedwig-server/bin/hedwig-daemon.sh start
starting , logging to /Users/test/src/bookkeeper/hedwig-server/logs/hedwig--sweetgreat-lm.log
JMX enabled by default
Usage: hedwig <command>
where command is one of:
server Run the hedwig server
console Run the hedwig admin console
help This help message
or command is the full name of a class with a defined main() method.
Environment variables:
{quote}
Being a daemon only makes sense for the server command, in this case, and in the bookkeeper case. The behaviour I expect from this script is that I run:
{quote}
$ bin/hedwig-daemon.sh start
{quote}
and the daemon starts.
I run
{quote}
$ bin/hedwig-daemon.sh stop
{quote}
and the daemon stops.
There should not be any other commandline arguments. Any configuration should be through hwenv.sh. Could you make the same changes for bookkeeper-daemon.sh also?
> provide stop scripts for hub server
> -----------------------------------
>
> Key: BOOKKEEPER-329
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-329
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.0.0, 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-329.diff
>
>
> as what we did in BOOKKEEPER-296, it would be better to provide similar script to start/stop hub server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-329) provide stop scripts for hub
server
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412365#comment-13412365 ]
Sijie Guo commented on BOOKKEEPER-329:
--------------------------------------
@Ivan. +1 for 4.1.1. these scripts are useful for users. and they are newly added scripts, which are easy to put them in 4.1.1.
> provide stop scripts for hub server
> -----------------------------------
>
> Key: BOOKKEEPER-329
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-329
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.0.0, 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-329.diff, BOOKKEEPER-329.diff_v2
>
>
> as what we did in BOOKKEEPER-296, it would be better to provide similar script to start/stop hub server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-329) provide stop scripts for hub
server
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-329:
---------------------------------
Fix Version/s: 4.1.1
> provide stop scripts for hub server
> -----------------------------------
>
> Key: BOOKKEEPER-329
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-329
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.0.0, 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0, 4.1.1
>
> Attachments: BOOKKEEPER-329.diff, BOOKKEEPER-329.diff_v2
>
>
> as what we did in BOOKKEEPER-296, it would be better to provide similar script to start/stop hub server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-329) provide stop scripts for hub
server
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411222#comment-13411222 ]
Uma Maheswara Rao G commented on BOOKKEEPER-329:
------------------------------------------------
{quote}
Also, there are things which we should never ever ever daemonize, such as console.
{quote}
Excellent point you have raised Ivan. Agree, accepting console options in daemon scripts will not be good. We should have restricted to accept only required stuff from daemon scripts.
Shall I reopen BK-296 for the amendment patch (instead of giving here for addressing Ivan's comments in BK scripts)? because relevant changes will be with the correct JIRA.
> provide stop scripts for hub server
> -----------------------------------
>
> Key: BOOKKEEPER-329
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-329
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.0.0, 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-329.diff
>
>
> as what we did in BOOKKEEPER-296, it would be better to provide similar script to start/stop hub server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-329) provide stop scripts for hub
server
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-329:
---------------------------------
Attachment: BOOKKEEPER-329.diff
attach a patch to provide script to stop hub server.
> provide stop scripts for hub server
> -----------------------------------
>
> Key: BOOKKEEPER-329
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-329
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.0.0, 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-329.diff
>
>
> as what we did in BOOKKEEPER-296, it would be better to provide similar script to start/stop hub server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-329) provide stop scripts for hub
server
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411781#comment-13411781 ]
Hudson commented on BOOKKEEPER-329:
-----------------------------------
Integrated in bookkeeper-trunk #601 (See [https://builds.apache.org/job/bookkeeper-trunk/601/])
BOOKKEEPER-329: provide stop scripts for hub server (sijie via ivank) (Revision 1360311)
Result = ABORTED
ivank :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/bin/bookkeeper-daemon.sh
* /zookeeper/bookkeeper/trunk/hedwig-server/bin/hedwig
* /zookeeper/bookkeeper/trunk/hedwig-server/bin/hedwig-daemon.sh
* /zookeeper/bookkeeper/trunk/hedwig-server/conf/hwenv.sh
* /zookeeper/bookkeeper/trunk/hedwig-server/conf/log4j.properties
> provide stop scripts for hub server
> -----------------------------------
>
> Key: BOOKKEEPER-329
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-329
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.0.0, 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-329.diff, BOOKKEEPER-329.diff_v2
>
>
> as what we did in BOOKKEEPER-296, it would be better to provide similar script to start/stop hub server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-329) provide stop scripts for hub
server
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-329:
---------------------------------
Attachment: BOOKKEEPER-329.diff_v2
attach a new patch to check service in hedwig-daemon.sh
> provide stop scripts for hub server
> -----------------------------------
>
> Key: BOOKKEEPER-329
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-329
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.0.0, 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-329.diff, BOOKKEEPER-329.diff_v2
>
>
> as what we did in BOOKKEEPER-296, it would be better to provide similar script to start/stop hub server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-329) provide stop scripts for hub
server
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410515#comment-13410515 ]
Ivan Kelly commented on BOOKKEEPER-329:
---------------------------------------
Hmmm, i disagree with needing it for localbookie, but we will need it for auditor pretty soon. The error needs to be more explicit though. If the <service> is not provided, we should error early and error loudly. Also, there are things which we should never ever ever daemonize, such as console.
I think for there should be a list of approved daemonizable commands,
{code}
case $command in
bookie|auditor)
echo doing $command
;;
*)
echo service must be one of bookie,auditor
;;
esac
{code}
> provide stop scripts for hub server
> -----------------------------------
>
> Key: BOOKKEEPER-329
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-329
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.0.0, 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-329.diff
>
>
> as what we did in BOOKKEEPER-296, it would be better to provide similar script to start/stop hub server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-329) provide stop scripts for hub
server
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450385#comment-13450385 ]
Sijie Guo commented on BOOKKEEPER-329:
--------------------------------------
committed as r1381890 in branch 4.1.
> provide stop scripts for hub server
> -----------------------------------
>
> Key: BOOKKEEPER-329
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-329
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.0.0, 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-329.diff, BOOKKEEPER-329.diff_v2
>
>
> as what we did in BOOKKEEPER-296, it would be better to provide similar script to start/stop hub server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-329) provide stop scripts for hub
server
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410489#comment-13410489 ]
Sijie Guo commented on BOOKKEEPER-329:
--------------------------------------
actually for bookkeeper-daemon.sh, you could use it to start a bookie server or a localbookie instance. if changed to what you suggested, we had to use it to just start a bookie server.
to keep consistent style, I provided similar start/stop script as bookkeeper for hedwig.
> provide stop scripts for hub server
> -----------------------------------
>
> Key: BOOKKEEPER-329
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-329
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.0.0, 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-329.diff
>
>
> as what we did in BOOKKEEPER-296, it would be better to provide similar script to start/stop hub server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-329) provide stop scripts for hub
server
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411263#comment-13411263 ]
Sijie Guo commented on BOOKKEEPER-329:
--------------------------------------
@Uma, I am ok to reopen BK-296 if it made changes more clearly.
> provide stop scripts for hub server
> -----------------------------------
>
> Key: BOOKKEEPER-329
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-329
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.0.0, 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-329.diff, BOOKKEEPER-329.diff_v2
>
>
> as what we did in BOOKKEEPER-296, it would be better to provide similar script to start/stop hub server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-329) provide stop scripts for hub
server
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411149#comment-13411149 ]
Sijie Guo commented on BOOKKEEPER-329:
--------------------------------------
agreed on checking service. would do the changes in the new patch.
> provide stop scripts for hub server
> -----------------------------------
>
> Key: BOOKKEEPER-329
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-329
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-server
> Affects Versions: 4.0.0, 4.1.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-329.diff
>
>
> as what we did in BOOKKEEPER-296, it would be better to provide similar script to start/stop hub server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira