You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/01/14 22:05:51 UTC

Review Request 16869: Run Various Requests in Parallel so that one does not wait on the other.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16869/
-----------------------------------------------------------

Review request for Ambari, Oleksandr Diachenko and Sumit Mohanty.


Bugs: AMBARI-4290
    https://issues.apache.org/jira/browse/AMBARI-4290


Repository: ambari


Description
-------

Run Various Requests in Parallel so that one does not wait on the other.


Diffs
-----

  ambari-server/conf/unix/ambari.properties ebb5d9c 
  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java af25149 
  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java 02c94b8 
  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java a1a25e0 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 6f8c884 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java a266cc6 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java bce150a 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 4e716dc 

Diff: https://reviews.apache.org/r/16869/diff/


Testing
-------

Failing test is broken at trunk.

Running org.apache.ambari.server.agent.TestHeartbeatMonitor
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.533 sec
Running org.apache.ambari.server.agent.TestHeartbeatHandler
Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.334 sec

Results :

Failed tests:   testDoWork(org.apache.ambari.server.state.scheduler.BatchRequestJobTest): (..)

Tests run: 1267, Failures: 1, Errors: 0, Skipped: 8

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11:27.673s
[INFO] Finished at: Tue Jan 14 23:27:15 FET 2014
[INFO] Final Memory: 22M/299M


Thanks,

Dmitro Lisnichenko


Re: Review Request 16869: Run Various Requests in Parallel so that one does not wait on the other.

Posted by Oleksandr Diachenko <od...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16869/#review31871
-----------------------------------------------------------

Ship it!


Ship It!

- Oleksandr Diachenko


On Jan. 14, 2014, 9:46 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16869/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2014, 9:46 p.m.)
> 
> 
> Review request for Ambari, Oleksandr Diachenko and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-4290
>     https://issues.apache.org/jira/browse/AMBARI-4290
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Run Various Requests in Parallel so that one does not wait on the other.
> 
> 
> Diffs
> -----
> 
>   ambari-server/conf/unix/ambari.properties ebb5d9c 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java af25149 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java 02c94b8 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java a1a25e0 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 6f8c884 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java a266cc6 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java bce150a 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 4e716dc 
> 
> Diff: https://reviews.apache.org/r/16869/diff/
> 
> 
> Testing
> -------
> 
> Failing test is broken at trunk.
> 
> Running org.apache.ambari.server.agent.TestHeartbeatMonitor
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.533 sec
> Running org.apache.ambari.server.agent.TestHeartbeatHandler
> Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.334 sec
> 
> Results :
> 
> Failed tests:   testDoWork(org.apache.ambari.server.state.scheduler.BatchRequestJobTest): (..)
> 
> Tests run: 1267, Failures: 1, Errors: 0, Skipped: 8
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 11:27.673s
> [INFO] Finished at: Tue Jan 14 23:27:15 FET 2014
> [INFO] Final Memory: 22M/299M
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 16869: Run Various Requests in Parallel so that one does not wait on the other.

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16869/
-----------------------------------------------------------

(Updated Jan. 14, 2014, 9:46 p.m.)


Review request for Ambari, Oleksandr Diachenko and Sumit Mohanty.


Changes
-------

fixed missing import after reverting imports


Bugs: AMBARI-4290
    https://issues.apache.org/jira/browse/AMBARI-4290


Repository: ambari


Description
-------

Run Various Requests in Parallel so that one does not wait on the other.


Diffs (updated)
-----

  ambari-server/conf/unix/ambari.properties ebb5d9c 
  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java af25149 
  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java 02c94b8 
  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java a1a25e0 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 6f8c884 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java a266cc6 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java bce150a 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 4e716dc 

Diff: https://reviews.apache.org/r/16869/diff/


Testing
-------

Failing test is broken at trunk.

Running org.apache.ambari.server.agent.TestHeartbeatMonitor
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.533 sec
Running org.apache.ambari.server.agent.TestHeartbeatHandler
Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.334 sec

Results :

Failed tests:   testDoWork(org.apache.ambari.server.state.scheduler.BatchRequestJobTest): (..)

Tests run: 1267, Failures: 1, Errors: 0, Skipped: 8

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11:27.673s
[INFO] Finished at: Tue Jan 14 23:27:15 FET 2014
[INFO] Final Memory: 22M/299M


Thanks,

Dmitro Lisnichenko


Re: Review Request 16869: Run Various Requests in Parallel so that one does not wait on the other.

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16869/
-----------------------------------------------------------

(Updated Jan. 14, 2014, 9:44 p.m.)


Review request for Ambari, Oleksandr Diachenko and Sumit Mohanty.


Changes
-------

reverted imports.


Bugs: AMBARI-4290
    https://issues.apache.org/jira/browse/AMBARI-4290


Repository: ambari


Description
-------

Run Various Requests in Parallel so that one does not wait on the other.


Diffs (updated)
-----

  ambari-server/conf/unix/ambari.properties ebb5d9c 
  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java af25149 
  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java 02c94b8 
  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java a1a25e0 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 6f8c884 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java a266cc6 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java bce150a 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 4e716dc 

Diff: https://reviews.apache.org/r/16869/diff/


Testing
-------

Failing test is broken at trunk.

Running org.apache.ambari.server.agent.TestHeartbeatMonitor
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.533 sec
Running org.apache.ambari.server.agent.TestHeartbeatHandler
Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.334 sec

Results :

Failed tests:   testDoWork(org.apache.ambari.server.state.scheduler.BatchRequestJobTest): (..)

Tests run: 1267, Failures: 1, Errors: 0, Skipped: 8

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11:27.673s
[INFO] Finished at: Tue Jan 14 23:27:15 FET 2014
[INFO] Final Memory: 22M/299M


Thanks,

Dmitro Lisnichenko


Re: Review Request 16869: Run Various Requests in Parallel so that one does not wait on the other.

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

> On Jan. 14, 2014, 9:36 p.m., Sumit Mohanty wrote:
> > Minor nit.
> > 
> > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java AND
> > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
> > -- Lets revert "import java.util.*;" back to fully expanded

I've just disabled this feature in IDEA, so it should not collapse it any more


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16869/#review31806
-----------------------------------------------------------


On Jan. 14, 2014, 9:46 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16869/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2014, 9:46 p.m.)
> 
> 
> Review request for Ambari, Oleksandr Diachenko and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-4290
>     https://issues.apache.org/jira/browse/AMBARI-4290
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Run Various Requests in Parallel so that one does not wait on the other.
> 
> 
> Diffs
> -----
> 
>   ambari-server/conf/unix/ambari.properties ebb5d9c 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java af25149 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java 02c94b8 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java a1a25e0 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 6f8c884 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java a266cc6 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java bce150a 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 4e716dc 
> 
> Diff: https://reviews.apache.org/r/16869/diff/
> 
> 
> Testing
> -------
> 
> Failing test is broken at trunk.
> 
> Running org.apache.ambari.server.agent.TestHeartbeatMonitor
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.533 sec
> Running org.apache.ambari.server.agent.TestHeartbeatHandler
> Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.334 sec
> 
> Results :
> 
> Failed tests:   testDoWork(org.apache.ambari.server.state.scheduler.BatchRequestJobTest): (..)
> 
> Tests run: 1267, Failures: 1, Errors: 0, Skipped: 8
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 11:27.673s
> [INFO] Finished at: Tue Jan 14 23:27:15 FET 2014
> [INFO] Final Memory: 22M/299M
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 16869: Run Various Requests in Parallel so that one does not wait on the other.

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16869/#review31806
-----------------------------------------------------------

Ship it!


Minor nit.

ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java AND
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
-- Lets revert "import java.util.*;" back to fully expanded

- Sumit Mohanty


On Jan. 14, 2014, 9:05 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16869/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2014, 9:05 p.m.)
> 
> 
> Review request for Ambari, Oleksandr Diachenko and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-4290
>     https://issues.apache.org/jira/browse/AMBARI-4290
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Run Various Requests in Parallel so that one does not wait on the other.
> 
> 
> Diffs
> -----
> 
>   ambari-server/conf/unix/ambari.properties ebb5d9c 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java af25149 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java 02c94b8 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java a1a25e0 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 6f8c884 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java a266cc6 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java bce150a 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 4e716dc 
> 
> Diff: https://reviews.apache.org/r/16869/diff/
> 
> 
> Testing
> -------
> 
> Failing test is broken at trunk.
> 
> Running org.apache.ambari.server.agent.TestHeartbeatMonitor
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.533 sec
> Running org.apache.ambari.server.agent.TestHeartbeatHandler
> Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.334 sec
> 
> Results :
> 
> Failed tests:   testDoWork(org.apache.ambari.server.state.scheduler.BatchRequestJobTest): (..)
> 
> Tests run: 1267, Failures: 1, Errors: 0, Skipped: 8
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 11:27.673s
> [INFO] Finished at: Tue Jan 14 23:27:15 FET 2014
> [INFO] Final Memory: 22M/299M
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>