You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/24 02:53:46 UTC

[GitHub] [doris] mrhhsg opened a new pull request, #10389: [fix]Make sure only call once set_dict_encoding_type for each ColumnReader

mrhhsg opened a new pull request, #10389:
URL: https://github.com/apache/doris/pull/10389

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   Describe the overview of changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] BiteTheDDDDt commented on pull request #10389: [fix]Make sure only call once set_dict_encoding_type for each ColumnReader

Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #10389:
URL: https://github.com/apache/doris/pull/10389#issuecomment-1165377823

   `std::once_flag` is used to process multiple threads, does we should use it on there?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] yiguolei merged pull request #10389: [fix]Make sure only call once set_dict_encoding_type for each ColumnReader

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #10389:
URL: https://github.com/apache/doris/pull/10389


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] mrhhsg commented on pull request #10389: [fix]Make sure only call once set_dict_encoding_type for each ColumnReader

Posted by GitBox <gi...@apache.org>.
mrhhsg commented on PR #10389:
URL: https://github.com/apache/doris/pull/10389#issuecomment-1165407748

   > `std::once_flag` is used to process multiple threads, does we should use it on there?
   `ColumnReader` maybe be used by multiple queries.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org